Skip to content

nixos/tests/{budgie,gnome-flashback}: unbreak#246743

Merged
bobby285271 merged 2 commits intoNixOS:masterfrom
bobby285271:fix/wait-for-x
Aug 3, 2023
Merged

nixos/tests/{budgie,gnome-flashback}: unbreak#246743
bobby285271 merged 2 commits intoNixOS:masterfrom
bobby285271:fix/wait-for-x

Conversation

@bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Aug 2, 2023

Description of changes

Started VMs for both, did some comparison with Fedora Budgie spin and I guess what needs to be fixed is the test instead of the xsessionWrapper 🤔

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Aug 2, 2023
@bobby285271 bobby285271 marked this pull request as draft August 2, 2023 09:15
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Aug 2, 2023
@bobby285271 bobby285271 force-pushed the fix/wait-for-x branch 2 times, most recently from 20cba41 to 80920a4 Compare August 2, 2023 10:52
@bobby285271
Copy link
Member Author

bobby285271 commented Aug 2, 2023

@ofborg test budgie gnome-flashback

@bobby285271 bobby285271 merged commit 58a4216 into NixOS:master Aug 3, 2023
@bobby285271 bobby285271 deleted the fix/wait-for-x branch August 3, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant