libavif: build gdk-pixbuf loader and thumbnailer#244723
Merged
ncfavier merged 1 commit intoNixOS:stagingfrom Jul 29, 2023
Merged
libavif: build gdk-pixbuf loader and thumbnailer#244723ncfavier merged 1 commit intoNixOS:stagingfrom
ncfavier merged 1 commit intoNixOS:stagingfrom
Conversation
10 tasks
ofborg
bot
requested review from
amaxine,
bobby285271,
cwyc,
dasj19,
hedning and
mkg20001
ofborg
bot
added
10.rebuild-darwin: 501+
jtojnar
reviewed
Jul 21, 2023
Member
Author
|
Hmm, looks like |
jtojnar
reviewed
Jul 22, 2023
AOMediaCodec/libavif#182 AOMediaCodec/libavif#977 Mostly mirrors webp-pixbuf-loader. Also use prefixed names for `loaders.cache` so that users can install multiple loaders in a profile without collisions, and move `bin/webp-thumbnailer` to `libexec/gdk-pixbuf-thumbnailer-webp` (and similarly for avif).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resurrecting #102189
Upstream now ships a
.thumbnailerwhich we just have to patch a little. I mostly followed the approach ofwebp-pixbuf-loaderand added anavif-thumbnailer.I kept the loader in
outrather than a separate output because 1. it doesn't seem to increase the size that much, and 2. doing the latter means that the.thumbnaileralso has to live in the loader output (to avoid cyclic references without), which means it won't work "out of the box".I also specialised
loaders.cachetowebp-loaders.cacheandavif-loaders.cacheto avoid collisions when installing multiple loaders into a profile. I can dolibrsvgtoo but it's a bit more of a hassle so I thought I'd ask first.Tested
webp-pixbuf-loader+libavifin my user profile with thunar/tumbler's DesktopThumbnailer enabled; both types of thumbnails are rendered correctly.Closes #102189
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)