Skip to content

qmapshack: 1.16.1 → 1.17.0#244704

Merged
sikmir merged 1 commit intoNixOS:masterfrom
sikmir:qmapshack
Aug 5, 2023
Merged

qmapshack: 1.16.1 → 1.17.0#244704
sikmir merged 1 commit intoNixOS:masterfrom
sikmir:qmapshack

Conversation

@sikmir
Copy link
Member

@sikmir sikmir commented Jul 21, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dotlambda July 21, 2023 19:46
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 21, 2023
@sikmir
Copy link
Member Author

sikmir commented Jul 21, 2023

Result of nixpkgs-review pr 244704 run on x86_64-linux 1

1 package built:
  • qmapshack

@nixos-discourse
Copy link

nixos-discourse commented Aug 4, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2499

OPNA2608
OPNA2608 approved these changes Aug 5, 2023
View reviewed changes
Copy link
Contributor

@OPNA2608 OPNA2608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 244704 run on x86_64-linux 1

1 package built:
  • qmapshack

qmapshack and qmaptool launch fine. Both segfault when -h is used to print their options, but also seems to happen on the old version. The other tools I don't know how to use, but they print their options fine.

Migration to regular stdenv.mkDerivation & other code changes seem fine. LGTM.

@sikmir sikmir merged commit cfff9bb into NixOS:master Aug 5, 2023
@sikmir sikmir deleted the qmapshack branch August 5, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OPNA2608 OPNA2608 OPNA2608 approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Qt mkDerivation is slightly broken, redundant and should be deprecated

3 participants

@sikmir @nixos-discourse @OPNA2608