Merged
Conversation
ofborg
bot
added
8.has: package (new)
bjornfor
reviewed
Jul 21, 2023
bjornfor
reviewed
Jul 21, 2023
github-actions
bot
added
the
6.topic: python
ofborg
bot
removed
10.rebuild-darwin: 1
bjornfor
reviewed
Jul 25, 2023
bjornfor
reviewed
Jul 25, 2023
bjornfor
reviewed
Jul 25, 2023
bjornfor
reviewed
Jul 25, 2023
bjornfor
approved these changes
Jul 25, 2023
Contributor
Author
|
Ok it doesn't work on non-NixOS systems because of missing 3d acceleration. |
Contributor
Author
|
@bjornfor, is my PR ready to merge? |
Contributor
|
Yes. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Plots is a graph plotting app for GNOME.
https://github.com/alexhuntley/Plots
It is broken on non-NixOS systems due to this issue #244459
On my NixOS VM it works perfectly.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)