Skip to content

Comments

lib.path.splitRoot: init#244358

Merged
roberth merged 2 commits intoNixOS:masterfrom
tweag:lib.path.parts
Jul 27, 2023
Merged

lib.path.splitRoot: init#244358
roberth merged 2 commits intoNixOS:masterfrom
tweag:lib.path.parts

Conversation

@infinisil
Copy link
Member

@infinisil infinisil commented Jul 19, 2023 •
edited
Loading

Description of changes

Creates a new function:

  • lib.path.splitRoot :: Path -> { root :: Path, subpath :: String }: Split a path into its parts. 
    lib.path.splitRoot /foo/bar
-> { root = /.; subpath = "./foo/bar"; }

This is part of the path library effort and needed for the implementation of file set combinators.

This work is sponsored by Antithesis ✨

Things done
  • Tests
  • Docs

@infinisil infinisil requested a review from edolstra as a code owner July 19, 2023 14:23
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Jul 19, 2023
@infinisil infinisil mentioned this pull request Jul 14, 2023
Closed
13 tasks
@infinisil infinisil changed the title lib.path.parts: init lib.path.parts: init Jul 19, 2023
@roberth
Copy link
Member

roberth commented Jul 19, 2023

You know I like parts, but I was kind of expecting this to do the splitting between / thing.
I'd frame this as making the path relative or splitting it from its root.
lib.path.splitRoot?

@infinisil infinisil mentioned this pull request Jul 19, 2023
Closed
7 tasks
@infinisil infinisil force-pushed the lib.path.parts branch 2 times, most recently from d2acf75 to 137e724 Compare July 19, 2023 15:33
@infinisil
Copy link
Member Author

infinisil commented Jul 19, 2023

I like it, applied!

roberth
roberth reviewed Jul 19, 2023
View reviewed changes
lib/path/default.nix Outdated
Copy link
Member

@roberth roberth Jul 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate that this concept does not have Nix documentation yet.

(no action required now)

@infinisil infinisil mentioned this pull request Jul 19, 2023
Merged
2 tasks
@fricklerhandwerk fricklerhandwerk changed the title lib.path.parts: init lib.path.splitRoot: init Jul 19, 2023
fricklerhandwerk
fricklerhandwerk reviewed Jul 19, 2023
View reviewed changes
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jul 20, 2023
@infinisil
Copy link
Member Author

infinisil commented Jul 20, 2023

I fixed the bug in nixdoc that removed all indentation: nix-community/nixdoc#62

That was just too annoying when we're trying to have some nice formatting in the docs!

roberth
roberth reviewed Jul 21, 2023
View reviewed changes
lib/path/default.nix Outdated
Copy link
Member

@roberth roberth Jul 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reader will wonder what's the problem with this? Surely / is the root.

I think it might be sensible to treat all "${storeDir}/${x}" as roots, but that's a discussion for another time.

Copy link
Member Author

@infinisil infinisil Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That feels like something that should be supported by lib.strings.* instead. The error could even redirect the user to that

infinisil and others added 2 commits July 26, 2023 23:20
@infinisil infinisil requested a review from roberth July 26, 2023 21:21
@infinisil
Copy link
Member Author

infinisil commented Jul 26, 2023

I think this is ready to be merged

roberth
roberth approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scoping out per-sublibrary and per-type docs.

@roberth roberth merged commit 399ac29 into NixOS:master Jul 27, 2023
@infinisil infinisil deleted the lib.path.parts branch July 27, 2023 12:56
@infinisil
Copy link
Member Author

infinisil commented Jul 27, 2023

Scoping out per-sublibrary and per-type docs.

Not sure what you mean with that, but thanks for the merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roberth roberth roberth approved these changes

@fricklerhandwerk fricklerhandwerk fricklerhandwerk approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees

No one assigned

Labels

6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@infinisil @roberth @fricklerhandwerk