systemd-sysupdate: init#243995
Merged
RaitoBezarius merged 4 commits intoNixOS:masterfrom Jul 26, 2023
Merged
Conversation
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
nikstur
force-pushed
the
systemd-sysupdate
branch
from
1990627 to
858767f
Compare
github-actions
bot
added
8.has: documentation
arianvp
reviewed
Jul 18, 2023
arianvp
reviewed
Jul 18, 2023
nikstur
force-pushed
the
systemd-sysupdate
branch
from
858767f to
39709e3
Compare
nikstur
force-pushed
the
systemd-sysupdate
branch
2 times, most recently
from
5dbab49 to
048c987
Compare
Kranzes
reviewed
Jul 19, 2023
nikstur
force-pushed
the
systemd-sysupdate
branch
3 times, most recently
from
321a6b1 to
e0e4b5c
Compare
Contributor
Author
|
@arianvp is this good to go now? |
arianvp
approved these changes
Jul 24, 2023
nikstur
added
the
12.approvals: 1
RaitoBezarius
approved these changes
Jul 26, 2023
Member
RaitoBezarius
left a comment
RaitoBezarius
left a comment
There was a problem hiding this comment.
This would greatly benefit from:
(a) adding yourself as a maintainer of the module.
(b) a Markdown documentation of this module for operational usage inside nixpkgs.
It's not a blocker for this PR.
nikstur
force-pushed
the
systemd-sysupdate
branch
from
e0e4b5c to
200c4a2
Compare
Contributor
Author
Ah I definitely meant to do this. Somehow missed it. Thank you for pointing it out. I'll write some docs in a separate PR. Ideally when I have collected some more insights on how to use it well with NixOS. |
If someone blindly copies this code, at least they have a sensible key type.
nikstur
force-pushed
the
systemd-sysupdate
branch
from
200c4a2 to
e6862fa
Compare
Contributor
Author
|
@ofborg test systemd-sysupdate |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Introduces systemd-sysupdate. Among other things, this enables partition based A/B updates for NixOS appliances that do not rely on the traditional NixOS generations mechanism.
The first commit factors the generation of a gpg-keyring out of
nixos/tests/systemd-nspawnintonixos/tests/common/gpg-keyring.nixso it can be re-used for testing systemd-sysupdate.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)