Merged
Conversation
This commit adds `pkgs.test.cross.sanity`, which is meant to be a carefully curated list of builds/packages that tend to break when refactoring our cross-compilation infrastructure. It should strike a balance between being small enough to fit in a single eval (i.e. not so large that hydra-eval-jobs is needed) so we can ask @ofborg to check it, yet should have good examples of things that often break. So, no buckshot `mapTestOnCross` calls here.
This was referenced Jul 13, 2023
ofborg
bot
added
the
6.topic: cross-compilation
ghost
mentioned this pull request
ghost
marked this pull request as ready for review
ofborg
bot
added
10.rebuild-darwin: 0
Author
|
@ofborg build test.cross.sanity |
Member
|
@ofborg build tests.cross.sanity |
1 similar comment
Author
|
@ofborg build tests.cross.sanity |
Author
|
tests.cross.sanity on x86_64-linux — Success Details |
ghost
commented
Jul 14, 2023
pkgs/test/cross/default.nix
Outdated
Author
There was a problem hiding this comment.
I think I know how to fix this, but I want to make sure I don't break native builds in doing so. My PowerPC hardware is offline until Monday, so for now I've just disabled pkgs.pkgsCross.powernv.pkgsBuildTarget.gcc.
Author
|
Rebased. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This commit adds
pkgs.test.cross.sanity, which is meant to be a carefully curated list of builds/packages that tend to break when refactoring our cross-compilation infrastructure.It should strike a balance between being small enough to fit in a single eval (i.e. not so large that hydra-eval-jobs is needed) so we can ask @ofborg to check it, yet should have good examples of things that often break. So, no buckshot
mapTestOnCrosscalls here.Closes #243320
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)