gcc: disable glibc<->libgcc circularity workaround for windows and LLVM#243249
Merged
1 commit merged intomasterfrom Jul 13, 2023
unknown repository
Merged
gcc: disable glibc<->libgcc circularity workaround for windows and LLVM#2432491 commit merged intomasterfrom unknown repository
1 commit merged intomasterfrom
unknown repository
Conversation
This essentially reverts #238154 if `isWindows` or `useLLVM`, the two cases where it caused breakage: #238154 (comment) Since #238154 exists mainly for `isGNU` (i.e. due to the glibc<->libgcc circular dependency) disabling it here isn't a big deal.
19 tasks
Member
|
Member
|
@ofborg build pkgsLLVM.stdenv |
Member
|
|
Author
Latest push should fix that. @ofborg build pkgsLLVM.stdenv |
Author
|
So this doesn't happen again: |
Author
|
pkgsLLVM.stdenv on x86_64-linux — Success Details |
wegank
approved these changes
Jul 13, 2023
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This essentially reverts #238154 if
isWindowsoruseLLVM, the two cases where it caused breakage.pkgsLLVM,pkgsCross.mingwW64broken by #238154 #243326Since #238154 exists mainly for
isGNU(i.e. due to the glibc<->libgcc circular dependency) disabling it here isn't a big deal.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)