Skip to content

test.cross.mbuffer: init#243248

Merged
1 commit merged intomasterfrom
unknown repository
Jul 14, 2023
Merged

test.cross.mbuffer: init#243248
1 commit merged intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jul 13, 2023

Description of changes

This adds a test case for the tricky issue encountered in

#213453

Note: this test currently fails.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

test.cross.mbuffer: init
18bbf33 
This adds a test case for the tricky issue encountered in

  #213453
@ghost ghost mentioned this pull request Jul 13, 2023
Closed
@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Jul 13, 2023
@ghost
Copy link
Author

ghost commented Jul 13, 2023

@ofborg build pkgs.tests.cross.mbuffer

(expected to fail)

@ghost
Copy link
Author

ghost commented Jul 13, 2023

Excellent!

       > mbuffer: warning: ignoring config file '/nix/store/gyg6zqfnx4250nkshaxsnp4x73hciwxa-mbuffer-aarch64-unknown-linux-gnu-20230301/etc/mbuffer.rc' from different user
       > hello
       >
       > qemu: uncaught target signal 5 (Trace/breakpoint trap) - core dumped
       > /build/.attr-0l2nkwhif96f51f4amnlf414lhl4rv9vh8iffyp431v6s28gsr90: line 1:     5 Done                    echo hello
       >          6 Trace/breakpoint trap   (core dumped) | /nix/store/g7qkr86y3109882hnpj11gl2hj64y6kn-qemu-8.0.2/bin/qemu-aarch64 /nix/store/gyg6zqfnx4250nkshaxsnp4x73hciwxa-mbuffer-aarch64-unknown-linux-gnu-20230301/bin/mbuffer
       For full logs, run 'nix log /nix/store/h1a2y55zgnfdc0lvmvyl3359jajz5f85-test-mbuffer.drv'.

This reproduces the failure observed in #213453.

Now I can fix it, and know that it will stay fixed.

@ghost ghost requested a review from Majiir July 13, 2023 11:07
@ghost ghost marked this pull request as ready for review July 13, 2023 11:07
@ghost ghost mentioned this pull request Jul 13, 2023
Closed
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 13, 2023
@ghost ghost changed the title pkgs.test.cross.mbuffer: init test.cross.mbuffer: init Jul 13, 2023
Majiir
Majiir approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@Majiir Majiir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test fails for me as expected on x86_64-linux.

@ghost
Copy link
Author

ghost commented Jul 14, 2023

Yeah, I'm still working on fixing this. It is the grand daddy of libgcc-glibc-insanity corner-cases, it exercises the weirdest codepath in that circularly-dependent pair of packages. Thank you for finding it.

If you're desperate for a fix I have a few hacks that work but are not mergeable.

@ghost ghost merged commit e36efdd into NixOS:master Jul 14, 2023
@ghost ghost deleted the pr/mbuffer-test branch July 14, 2023 19:52
@Majiir
Copy link
Contributor

Majiir commented Jul 14, 2023

If you're desperate for a fix I have a few hacks that work but are not mergeable.

I'm using a workaround (#213464) so no worries. Thank you for working on the proper fix - this problem is over my head.

@Artturin Artturin mentioned this pull request Jan 29, 2024
Open
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Majiir