Skip to content

gcc: remove -lc from SHLIB_LC instead of setting SHLIB_LC=""#243230

Closed
ghost wants to merge 1 commit intomasterfrom
unknown repository
Closed

gcc: remove -lc from SHLIB_LC instead of setting SHLIB_LC=""#243230
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Jul 13, 2023

Currently testing.

Description of changes

Fix for breakage of pkgsCross.

#238154 (comment)

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Fix for breakage of pkgsCross.<anything-windows-ish>
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 13, 2023
@ghost
Copy link
Author

ghost commented Jul 13, 2023

Rebased on top of #243248

@ofborg build pkgs.tests.cross.mbuffer

@ghost ghost closed this Oct 22, 2023
@ghost ghost deleted the fix-gccNoLibc branch October 22, 2023 07:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants