Skip to content

[treewide] Zig: update packages for Zig hook framework#242565

Merged
AndersonTorres merged 14 commits intoNixOS:masterfrom
atorres1985-contrib:zig-update-packages
Aug 5, 2023
Merged

[treewide] Zig: update packages for Zig hook framework#242565
AndersonTorres merged 14 commits intoNixOS:masterfrom
atorres1985-contrib:zig-update-packages

Conversation

@AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Jul 10, 2023

Description of changes

It basically removes a lot of repeating code!

A companion for #242397

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@AndersonTorres AndersonTorres changed the title Zig update packages Zig: update packages for ZIg framework Jul 10, 2023
@AndersonTorres AndersonTorres mentioned this pull request Jul 10, 2023
12 tasks
@AndersonTorres AndersonTorres changed the title Zig: update packages for ZIg framework Zig: update packages for Zig framework Jul 10, 2023
@AndersonTorres AndersonTorres changed the title Zig: update packages for Zig framework [treewide] Zig: update packages for Zig hook framework Jul 11, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jul 11, 2023
@AndersonTorres
Copy link
Member Author

AndersonTorres commented Jul 11, 2023

With this experiment, I declare #242397 finished!

Now it is time to polishing.

@AndersonTorres AndersonTorres mentioned this pull request Jul 12, 2023
12 tasks
@AndersonTorres
Copy link
Member Author

AndersonTorres commented Jul 13, 2023

Softwares converted

  • zls
  • zf (bugged)
  • waylock
  • river
  • mepo
  • blackshades
  • linuxwave
  • clipbuzz
  • findup
  • ncdu
  • bmake
  • colorstorm

@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Jul 15, 2023
@AndersonTorres
Copy link
Member Author

AndersonTorres commented Jul 19, 2023

@ofborg build pkgsLLVM.colorstorm pkgsLLVM.ncdu

@github-actions github-actions bot removed the 8.has: documentation This PR adds or changes documentation label Aug 2, 2023
AndersonTorres and others added 14 commits August 3, 2023 23:52
Also, a cosmetic refactor:

- Reorder parameter listing
- Use rec-less, overlay-style overridable recursive attributes (in effect since
#119942);
- Remove nested with (according to
https://nix.dev/recipes/best-practices#with-scopes)
Also, a cosmetic refactor:

- Reorder parameter listing
- Use rec-less, overlay-style overridable recursive attributes (in effect since
#119942);
- Remove nested with (according to
https://nix.dev/recipes/best-practices#with-scopes)
Also, a cosmetic refactor:

- Reorder parameter listing
- Use rec-less, overlay-style overridable recursive attributes (in effect since
#119942);
- Remove nested with (according to
https://nix.dev/recipes/best-practices#with-scopes)
Also, a cosmetic refactor:

- Reorder parameter listing
- Use rec-less, overlay-style overridable recursive attributes (in effect since
#119942);
- Remove nested with (according to
https://nix.dev/recipes/best-practices#with-scopes)
Also, a cosmetic refactor:

- Reorder parameter listing
- Use rec-less, overlay-style overridable recursive attributes (in effect since
#119942);
- Remove nested with (according to
https://nix.dev/recipes/best-practices#with-scopes)
- Add `meta.longDescription`
Also, a cosmetic refactor:

- Reorder parameter listing
- Use rec-less, overlay-style overridable recursive attributes (in effect since
#119942);
- Remove nested with (according to
https://nix.dev/recipes/best-practices#with-scopes)
Also, a cosmetic refactor:

- Reorder parameter listing
- Use rec-less, overlay-style overridable recursive attributes (in effect since
#119942);
- Remove nested with (according to
https://nix.dev/recipes/best-practices#with-scopes)
Also, a cosmetic refactor:

- Reorder parameter listing
- Use rec-less, overlay-style overridable recursive attributes (in effect since
#119942);
- Remove nested with (according to
https://nix.dev/recipes/best-practices#with-scopes)
Also, a cosmetic refactor:

- Reorder parameter listing
- Use rec-less, overlay-style overridable recursive attributes (in effect since
#119942);
- Remove nested with (according to
https://nix.dev/recipes/best-practices#with-scopes)
Also, a cosmetic refactor:

- Reorder parameter listing
- Use rec-less, overlay-style overridable recursive attributes (in effect since
#119942);
- Remove nested with (according to
https://nix.dev/recipes/best-practices#with-scopes)
Also, a cosmetic refactor:

- Reorder parameter listing
- Use rec-less, overlay-style overridable recursive attributes (in effect since
#119942);
- Remove nested with (according to
https://nix.dev/recipes/best-practices#with-scopes)
- Add `meta.changelog`
It's a color theme generator for editors and terminal emulators, rewritten in
Zig.

Co-authored-by: IogaMaster <[email protected]>
Co-authored-by: figsoda <[email protected]>
@AndersonTorres AndersonTorres marked this pull request as ready for review August 4, 2023 02:53
@AndersonTorres
Copy link
Member Author

It's incredible that it didn't clash.

@AndersonTorres
Copy link
Member Author

@ofborg build pkgs.colorstorm

@AndersonTorres AndersonTorres merged commit 631b5b9 into NixOS:master Aug 5, 2023
@AndersonTorres AndersonTorres deleted the zig-update-packages branch August 5, 2023 15:55
@figsoda figsoda added the 6.topic: zig Zig is an imperative, general-purpose, statically typed, compiled system programming language. label Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: zig Zig is an imperative, general-purpose, statically typed, compiled system programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants