Skip to content

[Backport release-23.05] nixos/nixpkgs: Don't check when _module.args.pkgs is set#239417

Merged
roberth merged 4 commits intorelease-23.05from
backport-238136-to-release-23.05
Jun 26, 2023
Merged

[Backport release-23.05] nixos/nixpkgs: Don't check when _module.args.pkgs is set#239417
roberth merged 4 commits intorelease-23.05from
backport-238136-to-release-23.05

Conversation

@github-actions
Copy link
Contributor

Bot-based backport to release-23.05, triggered by a label in #238136.

  • Before merging, ensure that this backport complies with the Criteria for Backporting.
    • Even as a non-commiter, if you find that it does not comply, leave a comment.

roberth and others added 4 commits June 23, 2023 17:18
This will let us make assertions involving _module.args.pkgs, which
is not an option but a value attribute, and therefore doesn't have
its own highestPrio to inspect. The new function gives us that info.

(cherry picked from commit 36ea2bb)
@roberth
Copy link
Member

roberth commented Jun 23, 2023

See original PR. Review still appreciated.
If nobody can review this, let's merge this in a couple of days at the latest, as it solves a hard to troubleshoot error message.

EDIT: reopened to trigger CI

@roberth roberth closed this Jun 23, 2023
@roberth roberth reopened this Jun 23, 2023
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jun 23, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 23, 2023
@roberth roberth merged commit 52ab2ec into release-23.05 Jun 26, 2023
@emilylange emilylange deleted the backport-238136-to-release-23.05 branch June 29, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant