Skip to content

binutils-unwrapped: add option to have gold as ld#239247

Merged
Artturin merged 2 commits intoNixOS:masterfrom
Artturin:fixlinkergold
Jul 17, 2023
Merged

binutils-unwrapped: add option to have gold as ld#239247
Artturin merged 2 commits intoNixOS:masterfrom
Artturin:fixlinkergold

Conversation

@Artturin
Copy link
Member

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't test with

import ./. { localSystem = { system = "x86_64-linux"; }; crossSystem = { system = "x86_64-linux"; linker = "gold"; }; }

fails with the normal localSystem != crossSystem issue > configure: error: C compiler cannot create executables

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh i can just do
:b (import ./. { localSystem = { system = "x86_64-linux"; }; crossSystem = { system = "aarch64-linux"; linker = "gold"; }; }).bash

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aarch64-unknown-linux-gnu-stage-final-gcc> checking whether we are using gold... yes

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 22, 2023
@Artturin Artturin requested a review from alyssais June 23, 2023 09:21
:b (import ./. { localSystem = { system = "x86_64-linux"; }; crossSystem = { system = "aarch64-linux"; linker = "gold"; }; }).bash
@Artturin Artturin marked this pull request as ready for review June 28, 2023 20:55
@Artturin Artturin requested a review from NickCao July 6, 2023 19:53
@Artturin Artturin merged commit 23bb062 into NixOS:master Jul 17, 2023
@Artturin Artturin deleted the fixlinkergold branch July 17, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant