lib/system: move toLosslessStringMaybe into lib/tests#239132
Merged
1 commit merged intomasterfrom Jun 23, 2023
unknown repository
Merged
lib/system: move toLosslessStringMaybe into lib/tests#2391321 commit merged intomasterfrom unknown repository
1 commit merged intomasterfrom
unknown repository
Conversation
toLosslessStringMaybe is not used by anything other than lib/tests, so it can be private to that file. I don't think this function was terribly well thought-through. If people start using it, we will become permanently dependent on the ability to test platforms for equality. It also makes the elaboration process more fragile, because it encourages code outside of nixpkgs to become sensitive to the minute details of how elaboration happens.
ghost
requested review from
Ericson2314,
alyssais,
edolstra,
infinisil and
matthewbauer
as code owners
ofborg
bot
added
10.rebuild-darwin: 0
Member
|
Should we do a deprecation period for |
Author
It was added just last week in 5ff6f51 |
alyssais
approved these changes
Jun 23, 2023
1 task
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
toLosslessStringMaybe is not used by anything other than lib/tests, so it can be private to that file.
I don't think this function was terribly well thought-through.
toLosslessStringMaybe plat == nullinto second-class citizens. Our long term direction should be away from assuming that a platform is just a string -- places where we make that assumption already cause massive headaches forpkgsStaticandpkgsLLVMwhosestdenv.hostPlatforms both fall into this category.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)