Conversation
The previous build system patch was incomplete and left the `wrapper.d` directory empty, leaving Bear unable to pick up any build commands at all and breaking the functional test suite, which we also weren't running. Switch to overriding CMake flags instead and add the patches and dependencies necessary to get the functional tests running to prevent a future regression. I've checked that the instructions in Nix's `doc/manual/src/contributing/hacking.md` work after this change, which is what started this yak shave in the first place.
|
Adding backport labels back to 22.11, because that's the version that Nix's flake pins to and it's awkward for Nix's hacking instructions to not work because of a package bug. |
ofborg
bot
added
10.rebuild-darwin: 1-10
|
Looks like some of the |
figsoda
added
the
12.approvals: 1
|
I fixed the majority of the Linux test case failures but there are a few remaining ones relating to arcane LD_PRELOAD interception stuff. I will try to see if I can get them fixed soon. |
|
As a casual observer who has also encountered the problems with the My only real contribution here is that for cross-compiling, the tests should probably be separated out from the build phase. Bear doesn't make it easy though, and I don't think I even got it working right, but for my own purposes, I don't care about the tests passing. Hope this is helpful. |
|
@emilazy ping |
|
Any chance we could merge this, and fix any remaining tests later? The bear on @emilazy's fork works significantly better for me than what's currently in nixpkgs. |
|
This needs a rebase as |
|
How can we move this forward? I'm happy do the rebase but I don't have perms to push to @emilazy 's branch. I can open a separate PR if useful. |
|
Go right ahead, I don't think @emilazy would mind. |
|
Closing in favor of #279035 |
8 participants
Description of changes
The previous build system patch was incomplete and left the
wrapper.ddirectory empty, leaving Bear unable to pick up any build commands at all and breaking the functional test suite, which we also weren't running. Switch to overriding CMake flags instead and add the patches and dependencies necessary to get the functional tests running to prevent a future regression.I've checked that the instructions in Nix's
doc/manual/src/contributing/hacking.mdwork after this change, which is what started this yak shave in the first place.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)