Merged
Conversation
Member
|
Mostly okay (err, actually really happy) with this, but I might leave the parameter in place and add an assertion that it's empty, so we can throw a helpful error message ("we've removed md5 support from nixpkgs; please use sha256 from now on" or something) for a while, instead of just breaking it. Nix packages do exist outside of nixpkgs and I hate breaking things with no helpful errors. |
fpletz
approved these changes
Mar 17, 2017
Member
Author
|
@copumpkin updated |
FRidh
approved these changes
Mar 21, 2017
Member
|
Awesome, thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4491
cc @domenkozar @edolstra