Skip to content

fetch-*: remove md5 support#23838

Merged
globin merged 2 commits intoNixOS:masterfrom
mayflower:remove-md5
Mar 21, 2017
Merged

fetch-*: remove md5 support#23838
globin merged 2 commits intoNixOS:masterfrom
mayflower:remove-md5

Conversation

@globin
Copy link
Member

@globin globin commented Mar 13, 2017

@mention-bot
Copy link

@globin, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bennofs and @edwtjo to be potential reviewers.

@copumpkin
Copy link
Member

copumpkin commented Mar 13, 2017

Mostly okay (err, actually really happy) with this, but I might leave the parameter in place and add an assertion that it's empty, so we can throw a helpful error message ("we've removed md5 support from nixpkgs; please use sha256 from now on" or something) for a while, instead of just breaking it. Nix packages do exist outside of nixpkgs and I hate breaking things with no helpful errors.

@domenkozar domenkozar added this to the 17.03 milestone Mar 13, 2017
@fpletz fpletz added 8.has: clean-up This PR removes packages or removes other cruft 9.needs: changelog This PR needs a changelog entry labels Mar 17, 2017
@globin
Copy link
Member Author

globin commented Mar 20, 2017

@copumpkin updated

@globin globin removed the 9.needs: changelog This PR needs a changelog entry label Mar 20, 2017
@globin globin merged commit c93eb74 into NixOS:master Mar 21, 2017
@globin globin deleted the remove-md5 branch March 21, 2017 12:27
@copumpkin
Copy link
Member

Awesome, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Get rid of md5 support for fixed-output derivations

6 participants