Skip to content

[staging-next] Backport patches to make old Mozilla stuff build#238247

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
K900:old-mozilla-bindgen-hax
Jun 17, 2023
Merged

[staging-next] Backport patches to make old Mozilla stuff build#238247
vcunat merged 1 commit intoNixOS:staging-nextfrom
K900:old-mozilla-bindgen-hax

Conversation

@K900
Copy link
Contributor

@K900 K900 commented Jun 17, 2023

Thunderbird builds at least

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Jun 17, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 17, 2023
@K900 K900 force-pushed the old-mozilla-bindgen-hax branch from 9c6b804 to 4c3f19a Compare June 17, 2023 13:12
@github-actions github-actions bot removed the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Jun 17, 2023
@K900 K900 force-pushed the old-mozilla-bindgen-hax branch from 4c3f19a to a28218f Compare June 17, 2023 13:44
@K900 K900 changed the title [staging-next] Hack bindgenHook to make old Mozilla stuff build [staging-next] Backport patches to make old Mozilla stuff build Jun 17, 2023
@K900 K900 marked this pull request as ready for review June 17, 2023 13:45
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Jun 17, 2023
@mweinelt
Copy link
Member

@ofborg test firefox-esr

@vcunat vcunat merged commit 05647e9 into NixOS:staging-next Jun 17, 2023
@K900 K900 deleted the old-mozilla-bindgen-hax branch July 27, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants