stdenv: updateAutotoolsGnuConfigScriptsHook unconditionally#237968
Conversation
Unlike autoreconfHook, updateAutotoolsGnuConfigScriptsHook adds almost no compilations. Therefore, in the interest of building the same source code on every platform wherever possible, let's eliminate the conditional guards around updateAutotoolsGnuConfigScriptsHook in stdenv.
ofborg
bot
added
10.rebuild-linux-stdenv
ghost
marked this pull request as ready for review
trofi
approved these changes
Jun 16, 2023
Contributor
trofi
left a comment
trofi
left a comment
There was a problem hiding this comment.
Huge +1 for making it unconditional. Thank you!
ghost
mentioned this pull request
12 tasks
Member
|
exposed that makeSetupHook is broken in __structuredAttrs __bootPackages discovered with
|
mccurdyc
pushed a commit
to mccurdyc/nixpkgs
that referenced
this pull request
Jul 3, 2023
Accidentally omitted from NixOS#237968.
4 tasks
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Unlike autoreconfHook, updateAutotoolsGnuConfigScriptsHook adds almost no compilations. Therefore, in the interest of building the same source code on every platform wherever possible, let's eliminate the conditional guards around updateAutotoolsGnuConfigScriptsHook in stdenv.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)