Skip to content

lib.systems.equals#237512

Merged
Artturin merged 3 commits intoNixOS:masterfrom
hercules-ci:lib-system-equals
Jun 15, 2023
Merged

lib.systems.equals#237512
Artturin merged 3 commits intoNixOS:masterfrom
hercules-ci:lib-system-equals

Conversation

@roberth
Copy link
Member

@roberth roberth commented Jun 13, 2023

Description of changes

Helps #237427
Cherry-picked from #231940

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@roberth roberth mentioned this pull request Jun 13, 2023
Closed
12 tasks
@alyssais alyssais requested a review from sternenseemann June 13, 2023 08:44
@roberth roberth mentioned this pull request Jun 13, 2023
Open
12 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jun 13, 2023
@Artturin Artturin merged commit 5ff6f51 into NixOS:master Jun 15, 2023
@ghost
Copy link

ghost commented Jun 17, 2023

Ugh, making sure people use this everywhere instead of == is going to be an endless game of whack-a-mole. Not to mention situations where people use == on attrsets which contain fooPlatforms as subcomponents.

@sternenseemann sternenseemann mentioned this pull request Jun 18, 2023
Closed
12 tasks
@sternenseemann
Copy link
Member

sternenseemann commented Jun 18, 2023

We can have our cake and eat it, too: 5d8e668

spikespaz added a commit to spikespaz/dotfiles that referenced this pull request Jun 23, 2023
@spikespaz
lib: builders: mkHost: circumvent crossSystem issue
c3f9883 
<NixOS/nixpkgs#237512>
<NixOS/nixpkgs#238136>
<NixOS/nixpkgs#238331>
@tie tie mentioned this pull request Sep 13, 2023
Closed
1 task
spikespaz added a commit to spikespaz/bird-nix-lib that referenced this pull request Sep 18, 2023
@spikespaz
lib: builders: mkHost: circumvent crossSystem issue
ba6570e 
<NixOS/nixpkgs#237512>
<NixOS/nixpkgs#238136>
<NixOS/nixpkgs#238331>
This was referenced Oct 30, 2023
Closed
Open
Open
@roberth roberth mentioned this pull request Mar 1, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alyssais alyssais Awaiting requested review from alyssais

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@edolstra edolstra Awaiting requested review from edolstra

@infinisil infinisil Awaiting requested review from infinisil

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@roberth @sternenseemann @Artturin