Skip to content

earthly: 0.6.23 -> 0.7.7#234965

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
konradmalik:earthly
Jun 2, 2023
Merged

earthly: 0.6.23 -> 0.7.7#234965
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
konradmalik:earthly

Conversation

@konradmalik
Copy link
Contributor

@konradmalik konradmalik commented May 30, 2023 •
edited
Loading

Description of changes

Changelog

  • Added myself as a maintainer since I'm using this software on a daily basis and can help
  • Re-enabled checks
  • removed shellrepeater as it does not exist anymore
  • updated ldflags according to the upstream Earthfile that takes the platform into consideration
  • disabled CGO as per upstream Earthfile
  • moved buildtags to tags
  • specified subPackages that we're compiling here (upstream Earthfile does the same)
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@konradmalik konradmalik requested a review from zoedsoupe May 30, 2023 08:47
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 30, 2023
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Jun 1, 2023
@konradmalik
Copy link
Contributor Author

konradmalik commented Jun 2, 2023

looked too late, linking the previous, different MR still waiting for reviews, not sure which one we'd like to keep: #224335

@konradmalik konradmalik changed the title earthly: 0.6.23 -> 0.7.6 earthly: 0.6.23 -> 0.7.7 Jun 2, 2023
@nixos-discourse
Copy link

nixos-discourse commented Jun 2, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2298

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jun 2, 2023
Closed
12 tasks
@SuperSandro2000 SuperSandro2000 merged commit 7042fa3 into NixOS:master Jun 2, 2023
@konradmalik konradmalik deleted the earthly branch June 3, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zoedsoupe zoedsoupe Awaiting requested review from zoedsoupe

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@konradmalik @nixos-discourse @SuperSandro2000