Skip to content

haskellPackages.http2: fix build with Darwin sandbox enabled#234132

Merged
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
reckenrode:http2-darwin-fix
May 26, 2023
Merged

haskellPackages.http2: fix build with Darwin sandbox enabled#234132
cdepillabout merged 1 commit intoNixOS:haskell-updatesfrom
reckenrode:http2-darwin-fix

Conversation

@reckenrode
Copy link
Contributor

@reckenrode reckenrode commented May 26, 2023

Description of changes

Another sandbox-related build failure on Darwin. http2 needs access to local networking to run its tests.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = relaxed set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label May 26, 2023
@reckenrode reckenrode changed the base branch from master to haskell-updates May 26, 2023 03:54
@reckenrode reckenrode force-pushed the http2-darwin-fix branch 2 times, most recently from 933cf39 to d8718a0 Compare May 26, 2023 03:55
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 26, 2023
@reckenrode reckenrode mentioned this pull request May 26, 2023
Closed
16 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 26, 2023
@cdepillabout
Copy link
Member

cdepillabout commented May 26, 2023

Requesting a Darwin reviewer on this PR as well. @NixOS/darwin-maintainers

@mikroskeem
Copy link
Member

mikroskeem commented May 26, 2023 •
edited
Loading

Result of nixpkgs-review pr 234132 run on aarch64-darwin 1

2 packages built:
  • haskellPackages.http2
  • haskellPackages.http2.doc (haskellPackages.http2.doc.doc)

nix run nixpkgs#nixpkgs-review -- pr 234132 --build-args '--relaxed-sandbox' --package haskellPackages.http2

@cdepillabout
Copy link
Member

cdepillabout commented May 26, 2023

Thanks again!

@cdepillabout cdepillabout merged commit 90fd702 into NixOS:haskell-updates May 26, 2023
@reckenrode reckenrode mentioned this pull request May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@reckenrode @cdepillabout @mikroskeem