Skip to content

pufferpanel: build frontend from source #234124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuperSandro2000 merged 3 commits into from
Jul 17, 2023
Merged

pufferpanel: build frontend from source #234124

SuperSandro2000 merged 3 commits into from
Jul 17, 2023

Conversation

@tie
Copy link
Member

@tie tie commented May 26, 2023 •
edited
Loading

Description of changes

This change updates the PufferPanel package to build frontend from source. Note that cross-compilation with buildNpmPackage seems to be broken (at least from aarch64-linux to x86_64-linux), but the frontend is platform-independent so we use pkgsBuildBuild.buildNpmPackage.

It is bundled with 2.6.7 version bump since it allows us to drop upstreamed patches.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tie tie requested a review from ckiee May 26, 2023 03:00
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 26, 2023
@tie tie requested a review from SuperSandro2000 June 6, 2023 07:12
SuperSandro2000
SuperSandro2000 reviewed Jun 6, 2023
View reviewed changes
tie
tie commented Jun 10, 2023
View reviewed changes
SuperSandro2000
SuperSandro2000 reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if that is not working than we have a special case herre which probably requires some more work.

@tie
Copy link
Member Author

tie commented Jun 16, 2023 •
edited
Loading

if that is not working than we have a special case herre which probably requires some more work.

I think I’ve tracked down the cross-compilation issue to Nodejs build system. Currently pkgsCross.gnu64.nodejs fails because -m64 flag is passed for both host and target toolchain on aarch64-linux.
https://github.com/nodejs/node/blob/57679e1c97a90057d5ca9e1f0d1f3c6255d20200/common.gypi#L416-L435

I can successfully build pkgsCross.gnu64.nodejs_20 (but not 18) with the 840141d commit applied. When overriding buildNpmPackage to nodejs_20, pkgsCross.gnu64.pufferpanel successfully builds and runs on target system.

@tie tie force-pushed the pufferpanel-frontend branch from c8d11f0 to abe082d Compare June 16, 2023 08:20
@tie tie mentioned this pull request Jun 18, 2023
Merged
12 tasks
tie added 3 commits July 8, 2023 10:49
@tie
pufferpanel: build frontend from source
24556f7 
This change updates the PufferPanel package to build frontend from
source.
@tie
pufferpanel: remove pathDeps argument
406467c 
This change removes pathDeps argument from pufferpanel package. It is
rather wasteful to rebuild package to change PATH environment variable.
Instead, users should create a separate wrapper derivation or set
services.pufferpanel.extraPackages in NixOS configuration.
@tie
pufferpanel: 2.6.6 -> 2.6.7
da4bcf4
@tie tie force-pushed the pufferpanel-frontend branch from abe082d to da4bcf4 Compare July 8, 2023 07:51
@SuperSandro2000 SuperSandro2000 merged commit 27eb270 into NixOS:master Jul 17, 2023
@tie tie deleted the pufferpanel-frontend branch March 7, 2025 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@ckiee ckiee Awaiting requested review from ckiee

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tie @SuperSandro2000