meson: fix build with case-sensitive store on Darwin#234105
Merged
wegank merged 2 commits intoNixOS:stagingfrom May 26, 2023
Merged
meson: fix build with case-sensitive store on Darwin#234105wegank merged 2 commits intoNixOS:stagingfrom
wegank merged 2 commits intoNixOS:stagingfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 501+
Member
|
Two basic questions:
As I have said before, I have no access to a Darwin machine. |
16 tasks
Contributor
Author
|
The patch shouldn’t affect users on case-insensitive stores. All it does is change the casing of |
wegank
reviewed
May 26, 2023
wegank
reviewed
May 26, 2023
Co-authored-by: Weijia Wang <[email protected]>
wegank
approved these changes
May 26, 2023
Member
|
@ofborg build meson meson.passthru.tests |
It is now merged upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I run Darwin with a case-sensitive store because it’s offered as an option. Meson is the first thing that actually broke because of it. This patch corrects the casing of “foundation” references in some of the tests that expect to find it.
I did not run
nixpkgs-reviewbecause this change causes a lot of rebuilds, but I did rebuild a number of packages as part of my work on #229786.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)