Skip to content

mupdf: 1.21.1 -> 1.22.1#233961

Merged
wegank merged 1 commit intoNixOS:stagingfrom
idlip:mupdf
May 25, 2023
Merged

mupdf: 1.21.1 -> 1.22.1#233961
wegank merged 1 commit intoNixOS:stagingfrom
idlip:mupdf

Conversation

@idlip
Copy link
Contributor

@idlip idlip commented May 25, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@idlip idlip requested a review from afh May 25, 2023 09:58
@ofborg ofborg bot requested review from fpletz and vrthra May 25, 2023 10:27
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels May 25, 2023
@wegank
Copy link
Member

wegank commented May 25, 2023

Please rebase on staging, thanks.

@wegank wegank marked this pull request as draft May 25, 2023 12:07
@idlip
Copy link
Contributor Author

idlip commented May 25, 2023 •
edited
Loading

I'm still novice with git, I tried to explore on this.

Is this correct now?

Let me know if I have to do something with this, Thank you!

@github-actions github-actions bot added 6.topic: kernel The Linux kernel 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: stdenv Standard environment 6.topic: vim Advanced text editor labels May 25, 2023
@idlip idlip changed the base branch from master to staging May 25, 2023 13:58
@github-actions github-actions bot removed 6.topic: vim Advanced text editor 6.topic: kernel The Linux kernel 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: stdenv Standard environment labels May 25, 2023
@wegank wegank marked this pull request as ready for review May 25, 2023 13:59
@wegank
Copy link
Member

wegank commented May 25, 2023

There is a guide in CONTRIBUTING.md, but it already looks like the rebasing is successful. You can choose to close one of the PRs.

@idlip
Copy link
Contributor Author

idlip commented May 25, 2023

ah I realized, it was just a step closer.

Magit (emacs) is super interactive and super handy!

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. labels May 25, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels May 25, 2023
@wegank wegank merged commit ef12350 into NixOS:staging May 25, 2023
@idlip idlip deleted the mupdf branch November 24, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afh afh Awaiting requested review from afh

@fpletz fpletz Awaiting requested review from fpletz

@vrthra vrthra Awaiting requested review from vrthra

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@idlip @wegank