Skip to content

libopenmpt: 0.6.10 -> 0.7.1#232304

Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
OPNA2608:update/libopenmpt
May 25, 2023
Merged

libopenmpt: 0.6.10 -> 0.7.1#232304
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
OPNA2608:update/libopenmpt

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented May 16, 2023 •
edited
Loading

Description of changes

New minor version, so shall not be in 23.05 (upstream maintains several minor version series' in parallel, upcoming stable should be fine on 0.6.x). libopenmpt.bin tested, nothing more yet.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@OPNA2608 OPNA2608 mentioned this pull request May 16, 2023
Merged
12 tasks
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 16, 2023
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented May 17, 2023

Checked ffmpeg_6-full, srb2, tauon and audacious on x86_64-linux, seems to work there.

@ofborg build ffmpeg_6-full srb2 tauon audacious

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented May 17, 2023 •
edited
Loading

Oh right, this is going to staging… Don't think OfBorg is gonna manage to test this then, sigh.

Edit: aarch64-linux actually managed to not time out, wack.

@OPNA2608 OPNA2608 marked this pull request as ready for review May 17, 2023 13:40
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented May 20, 2023 •
edited
Loading

Also tested libopenmpt.bin and ffmpeg_6-full on x86_64-darwin, hope that's good enough.

image

@nixos-discourse
Copy link

nixos-discourse commented May 20, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2246

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented May 25, 2023

lets hope for the best :)

@SuperSandro2000 SuperSandro2000 merged commit 7a47bec into NixOS:staging May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OPNA2608 @nixos-discourse @SuperSandro2000