llvmPackages.lldb: deduplicate >10#230387
Conversation
ofborg
bot
requested review from
Ericson2314,
alyssais,
dtzWill,
lovek323,
primeos,
rrbutani and
sternenseemann
ofborg
bot
added
10.rebuild-darwin: 1-10
sternenseemann
left a comment
sternenseemann
left a comment
There was a problem hiding this comment.
Another more general point I am wondering about if the common expression shouldn't be a function that returns a package function. That way we could have a distinction between overrideable inputs (e.g. monorepoSrc and arguments that just customize the common expression (like patches), but are not an interface, really.
This could also save us extreme version comparison awkwardness. An example for this could be GHC's common-hadrian.nix or the SBCL common expression.
There was a problem hiding this comment.
(May be nice to use substituteAll for this in the future, but can be a different PR.)
There was a problem hiding this comment.
It'll cause a hash change
(callPackage
({ substituteAll, libclang }: substituteAll
{
src = ./lldb/resource-dir.patch;
clangLibDir = "${libclang.lib}/lib";
})
{ })There was a problem hiding this comment.
Yes, something for a future cleanup I'd say!
Artturin
force-pushed
the
llvmsplit1
branch
2 times, most recently
from
1c94421 to
8068ccc
Compare
ofborg
bot
added
10.rebuild-darwin: 11-100
ofborg
bot
added
10.rebuild-darwin: 0
rrbutani
added
the
6.topic: llvm/clang
3 participants
Once reviewed the commits will be squashed
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)