Closed
Conversation
bryanhonof
force-pushed
the
bryanhonof/flottbot-init
branch
from
11bbd5b to
d761f1c
Compare
ofborg
bot
added
8.has: package (new)
Member
|
Result of 1 package failed to build:
|
Janik-Haag
reviewed
May 15, 2023
Janik-Haag
suggested changes
May 15, 2023
Member
|
@bryanhonof are you still interested? |
Member
Author
|
@Janik-Haag Yes, I am. Will just have to find some time to finish this. 😊 |
Janik-Haag
reviewed
Aug 7, 2023
Member
Janik-Haag
left a comment
Janik-Haag
left a comment
There was a problem hiding this comment.
In there is ./result/bin/scripts which just prints Hi from Go which seems like it shouldn't be there.
|
|
||
| subPackages = [ ]; | ||
|
|
||
| doCheck = false; # Tries to do some networking :( |
Member
There was a problem hiding this comment.
If I set this to true the test run just fine o.O
nix-build -A flottbot
this derivation will be built:
/nix/store/h5m8q5j99nsnp7lp9xgpqzijvgcspnid-flottbot-0.12.0.drv
building '/nix/store/h5m8q5j99nsnp7lp9xgpqzijvgcspnid-flottbot-0.12.0.drv'...
unpacking sources
unpacking source archive /nix/store/wk3cahkfvxwklcbdham4xf8gnr5jcsc2-source
source root is source
patching sources
configuring
building
Building subPackage ./cmd/flottbot
Building subPackage ./config-example/scripts
Building subPackage ./core
Building subPackage ./handlers
Building subPackage ./models
Building subPackage ./remote
Building subPackage ./remote/cli
Building subPackage ./remote/discord
Building subPackage ./remote/gchat
Building subPackage ./remote/scheduler
Building subPackage ./remote/slack
Building subPackage ./remote/telegram
Building subPackage ./utils
Building subPackage ./version
buildPhase completed in 38 seconds
running tests
ok github.com/target/flottbot/core 2.035s
ok github.com/target/flottbot/handlers 1.018s
ok github.com/target/flottbot/utils 0.010s
ok github.com/target/flottbot/version 0.003s
checkPhase completed in 33 seconds
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2g1p03mqx4kjr668zj9xhx3jnnmlk750-flottbot-0.12.0
shrinking /nix/store/2g1p03mqx4kjr668zj9xhx3jnnmlk750-flottbot-0.12.0/bin/scripts
patchelf: cannot find section '.dynamic'. The input file is most likely statically linked
shrinking /nix/store/2g1p03mqx4kjr668zj9xhx3jnnmlk750-flottbot-0.12.0/bin/flottbot
checking for references to /build/ in /nix/store/2g1p03mqx4kjr668zj9xhx3jnnmlk750-flottbot-0.12.0...
patchelf: cannot find section '.dynamic'. The input file is most likely statically linked
patching script interpreter paths in /nix/store/2g1p03mqx4kjr668zj9xhx3jnnmlk750-flottbot-0.12.0
stripping (with command strip and flags -S) in /nix/store/2g1p03mqx4kjr668zj9xhx3jnnmlk750-flottbot-0.12.0/bin
/nix/store/2g1p03mqx4kjr668zj9xhx3jnnmlk750-flottbot-0.12.0
which test did you have prolems with?
Member
Author
There was a problem hiding this comment.
Don't really remember. Maybe they removed/fixed that test case in 0.12.0. I'll try agian.
|
|
||
| vendorSha256 = "sha256-6j1nQBlFqd78v/CNV7ivwYZ5CEzGh+An6xcQr4dAkAs="; | ||
|
|
||
| subPackages = [ ]; |
Member
Author
There was a problem hiding this comment.
Probably copy/paste from another Go package, sorry. 😅
Co-authored-by: Janik <[email protected]>
Janik-Haag
reviewed
Aug 8, 2023
Member
Janik-Haag
left a comment
Janik-Haag
left a comment
There was a problem hiding this comment.
This should be good to go after addressing the current discussions and squashing commits so we only have the flottbot: init at 0.11.0 commit.
|
|
||
| vendorSha256 = "sha256-6j1nQBlFqd78v/CNV7ivwYZ5CEzGh+An6xcQr4dAkAs="; | ||
|
|
||
| subPackages = [ ]; |
|
|
||
| subPackages = [ ]; | ||
|
|
||
| doCheck = false; # Tries to do some networking :( |
13 tasks
Member
Author
|
Closing in favor of #290084 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Initialize flottbot at version 0.11.0
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)