Skip to content

tone: fix build, update description, restrict the platform to "x86_64-linux"#229434

Merged
SuperSandro2000 merged 4 commits intoNixOS:masterfrom
natsukium:tone/fix
May 4, 2023
Merged

tone: fix build, update description, restrict the platform to "x86_64-linux"#229434
SuperSandro2000 merged 4 commits intoNixOS:masterfrom
natsukium:tone/fix

Conversation

@natsukium
Copy link
Member

@natsukium natsukium commented May 2, 2023

Description of changes

closes #229297

fix https://hydra.nixos.org/build/218099597

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@natsukium natsukium added the 0.kind: build failure A package fails to build label May 2, 2023
@natsukium
Copy link
Member Author

natsukium commented May 2, 2023

Result of nixpkgs-review pr 229434 run on x86_64-linux 1

2 packages built:
  • audiobookshelf
  • tone

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 2, 2023
@ofborg ofborg bot requested a review from jvanbruegge May 2, 2023 09:30
natsukium
natsukium commented May 2, 2023
View reviewed changes
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label May 2, 2023
jvanbruegge
jvanbruegge approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@jvanbruegge jvanbruegge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@natsukium natsukium added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 3, 2023
@nixos-discourse
Copy link

nixos-discourse commented May 3, 2023

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/2167

@SuperSandro2000 SuperSandro2000 changed the title tone: fix build tone: fix build, update description, restrict the platform to "x86_64-linux" May 4, 2023
@SuperSandro2000 SuperSandro2000 merged commit 0f4252a into NixOS:master May 4, 2023
@natsukium natsukium deleted the tone/fix branch May 4, 2023 16:57
@natsukium natsukium mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jvanbruegge jvanbruegge jvanbruegge approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

0.kind: build failure A package fails to build 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: Audiobookshelf

4 participants

@natsukium @nixos-discourse @jvanbruegge @SuperSandro2000