Merged
Conversation
12 tasks
ofborg
bot
added
10.rebuild-darwin: 11-100
Member
|
That's not how we usually handle Vulkan-* things. Only Yuzu depends on it, and we just override it for Yuzu. But, the only benefit from keeping this SDK-strict, is not changing the hash so frequently. So I'm not opposed to changing it, just stating the obvious here. |
Contributor
Author
|
I'm hoping we get a new SDK release by the next staging-next, personally, but this will also probably be useful for other things soon. |
K900
requested review from
Ericson2314,
RaitoBezarius,
alyssais and
matthewbauer
as code owners
Atemu
added a commit
to Atemu/nixpkgs
that referenced
this pull request
May 14, 2023
The VK loader finds the 32-bit layer first and does not attempt to load the 64-bit layer afterwards; likely because it shares the same name. Simply giving them different names fixes the issue; both layers are tried and the correct one succeeds. A similar patter is employed by obs-vkcapture which continued working after NixOS#228870. Fixes NixOS#230978
This was referenced May 14, 2023
12 tasks
kira-bruneau
pushed a commit
to kira-bruneau/nur-packages
that referenced
this pull request
May 24, 2023
The VK loader finds the 32-bit layer first and does not attempt to load the 64-bit layer afterwards; likely because it shares the same name. Simply giving them different names fixes the issue; both layers are tried and the correct one succeeds. A similar patter is employed by obs-vkcapture which continued working after NixOS/nixpkgs#228870. Fixes NixOS/nixpkgs#230978
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Those aren't part of a LunarG SDK release yet, but Yuzu (TBD) needs 1.3.246 or above, so provide that.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)