Conversation
This will make it possible to check whether we can use pkgsStatic opportunistically, in places like busybox-sandbox-shell, which currently decides not to use pkgsStatic based on a hard-coded set of platforms.
musl now supports RISC-V. Let's centralise musl availability checks in musl.meta.platforms, so we don't have to keep cleaning up ad-hoc checks like this all over the tree.
|
And I think |
In theory, but the check we'd want to use ( (We don't want to just check for musl there, because pkgsStatic only means musl on Linux.) |
alyssais
added
6.topic: musl
ofborg
bot
added
10.rebuild-darwin: 0
|
freshBootstrapTools successfully built on riscv64-linux by 0x4a6f (#exotic:nixos.org) |
|
The change looks reasonable to me, but can we somehow subtract the bad platforms instead of listing the good ones? |
We can, but I don't think we should. |
3 participants
Description of changes
This will make it possible to check whether we can use pkgsStatic opportunistically, in places like busybox-sandbox-shell, which currently decides not to use pkgsStatic based on a hard-coded set of platforms.
I haven't actually changed busybox-sandbox-shell to use it yet, because that would just cause conflicts with #227560, so we can do it later.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)