Skip to content

makeFontsConf: add darwin system fonts#228619

Merged
veprbl merged 1 commit intoNixOS:stagingfrom
xworld21:fontconfig-darwin-system-fonts
Apr 28, 2023
Merged

makeFontsConf: add darwin system fonts#228619
veprbl merged 1 commit intoNixOS:stagingfrom
xworld21:fontconfig-darwin-system-fonts

Conversation

@xworld21
Copy link
Contributor

@xworld21 xworld21 commented Apr 27, 2023

Description of changes

Add further non-NixOS system font folders on macOS (idea mentioned in #228196 (comment)).

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 27, 2023
@SuperSandro2000 SuperSandro2000 requested a review from a team April 28, 2023 13:24
@veprbl veprbl merged commit 0949f3c into NixOS:staging Apr 28, 2023
@xworld21 xworld21 deleted the fontconfig-darwin-system-fonts branch April 28, 2023 19:37
@xworld21
Copy link
Contributor Author

Oh, I could have tagged the darwin maintainers – good to know!

selmison pushed a commit to selmison/nixpkgs that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants