python310Packages.cryptography: don't depend on pytest-benchmark#228439
Merged
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom Apr 28, 2023
Merged
python310Packages.cryptography: don't depend on pytest-benchmark#228439SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
SuperSandro2000 merged 2 commits intoNixOS:stagingfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 501+
SuperSandro2000
approved these changes
Apr 27, 2023
dotlambda
force-pushed
the
pytest-benchmark-test
branch
from
3f8c7a2 to
c6355a7
Compare
Member
Author
|
FYI Cryptography's benchmarks also weren't run before this change. |
Member
|
/cc PR #229429 |
Member
|
I am going to create a PR which disables those tests ionelmc/pytest-benchmark#231 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)