[staging-next] notmuch: fix darwin build#228318
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Apr 26, 2023
marsam:fix-notmuch-darwin-build
Merged
[staging-next] notmuch: fix darwin build#228318vcunat merged 1 commit intoNixOS:staging-nextfrom marsam:fix-notmuch-darwin-build
vcunat merged 1 commit intoNixOS:staging-nextfrom
marsam:fix-notmuch-darwin-build
Conversation
notmuch tries to compile the ruby binding with custom CFLAGS which collides with the CFLAGS created by Ruby mkmf. This caused notmuch to fail on Darwin, because it requires `-fdeclspec` and it was removed from CFLAGS.
12 tasks
Member
|
@ofborg build afew |
ofborg
bot
added
10.rebuild-darwin: 11-100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
notmuch tries to build its ruby binding with custom CFLAGS which collides with the CFLAGS created by Ruby mkmf.
This caused notmuch to fail on Darwin, because it requires
-fdeclspecand it was removed from CFLAGS.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)