1. Add a comment near the patch, and squash this commit to the
2. Instead of the substituteInPlace used in preBuild, use the Nix function substituteAll.
3. Squash this commit to the previous, init commit.

Same here, doCheck = false won't hurt.

Is it possible to use disabledTests here instead?

No, that didn't work because it's a parametrized test... but the test is passing in the latest upstream release now.

Same here.

Is this package supposed to be available as a python module as well?

It required as a module for https://github.com/notofonts/notobuilder/ which we would need if we ever want to build noto-fonts from source

All the packages in this PR should be available as Python modules (since a lot of font build processes will depend on them that way, even if they're really a command line tool like fontbakery). Plus for all those packages where upstream's docs give some indication that the tool is designed to be invoked from the command line, I've exported them as Python applications as well.

Nit: It might be safer to use installShellFiles.

Tests that have open PRs, please use fetchpatch. I guess many of these patches are already merged upstream so hopefully this will look different after you'd revisit this PR.

Hmm interesting. Could you explain this a bit in a comment?

This is a bit of a dodgy hack and I shouldn't have left it in (not without a comment).

The actual problem is the classic pytest import confusion. Because of pytest's manipulations of sys.path, the test process ends up importing kurbopy/__init__.py from the source directory, which does not contain the built .so, and so it fails like this:

/nix/store/qp5zys77biz7imbk6yy85q5pdv7qk84j-python3-3.11.6/lib/python3.11/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/test_basic.py:1: in <module>
    from kurbopy import Point, Vec2, TranslateScale
kurbopy/__init__.py:1: in <module>
    from .kurbopy import Point as Point
E   ModuleNotFoundError: No module named 'kurbopy.kurbopy'

We want it to import kurbopy from the nix store via PYTHONPATH instead.

So this hack was stealing $dist and using it to populate the source directory with a usable copy of the built .so, but a proper solution would be to make pytest import kurbopy from the installed directory like a proper installCheckPhase is supposed to do.

Pytest has an --import-mode option which should help with that kind of mess. But no matter what I do, sys.path always imports from . first. I think it's because pytestCheckHook does python -m pytest, and that's one of the side effects noted in the docs.

Anyway, I can just hack it to delete the module from the source directory in preCheck, so that it imports the installed copy from the nix store instead. With a comment explaining what's going on. :-)

Anyway, I can just hack it to delete the module from the source directory in preCheck, so that it imports the installed copy from the nix store instead. With a comment explaining what's going on. :-)

Thanks for the thorough explanation @danc86 . Could you do me please 1 more favor? In the very well written comment, could you mention that this is a common issue in nixpkgs and it is investigated in #255262 ?

The PR should be ready after issue #255262 is mentioned.

Sure, I've reworded the comment to mention #255262.