nixos/lib/make-disk-image: introduce noNixStore option#227883
Draft
RaitoBezarius wants to merge 1 commit intomasterfrom
Draft
nixos/lib/make-disk-image: introduce noNixStore option#227883RaitoBezarius wants to merge 1 commit intomasterfrom
noNixStore option#227883RaitoBezarius wants to merge 1 commit intomasterfrom
Conversation
Sometimes, we want to use the host nix store for everything because it's more convenient. To do so, we need to "not install" the nix store in the target disk image. We trick nixos-install by mount binding the host nix store into the $root/nix folder and letting Nix do the idempotency thing.
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Sometimes, we want to use the host nix store for everything because it's more convenient.
To do so, we need to "not install" the nix store in the target disk image.
We trick nixos-install by mount binding the host nix store into the $root/nix folder and letting Nix do the idempotency thing.
It's unfinished : the mount is visible only *inside the namespace, we run nixos-install outside of it.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)