chromium: (cross) invoke ungoogled-chromium via buildPackages#227710
Conversation
ghost
changed the title
ghost
changed the title
ofborg
bot
added
the
6.topic: cross-compilation
ofborg
bot
added
10.rebuild-darwin: 0
|
Alright, this project will need to wait until after ZHF. |
ghost
marked this pull request as draft
|
Thanks, while the title accurately describes what you did, it's not immediately obvious to me what problem it actually solves. Is cross-compilation broken currently and this is the fix? |
It is one small part of the fix. I have one large PR (not yet submitted) and a bunch of smaller ones that can be reviewed (and potentially merged) separately from it. Here are the smaller PRs; all draftified because I'm not going to have the big one done in time:
Edit: dammit, pasted the wrong list of PRs. |
Yes, very much so. Or rather I don't think nixpkgs' chromium ever did cross compile correctly.
Well, if you cherry-pick all the above PRs except this one and on a non-aarch64 machine, you'll get a build failure when your non-aarch64 machine tries to execute a python script in ungoogled-chromium which had its shebang patched to something like So basically it's trying to execute the aarch64 python binary on your build machine (which is not aarch64). This is the fix for that one specific problem. There are many others (in chromium -- I think this is the only one in the ungoogled-chromium portion). |
The other reason I broke them up is in case this project creates problems down the line -- it will be easier to |
|
Thanks for the clarification and great work! Cross-compilation (aarch64) will become increasingly more important.
Yeah, that's what I thought but just wanted to make sure I got it :) |
ungoogled-chromium is, contrary to its name, not a build of chromium. It is a patched copy of chromium's *source code*. Therefore, it needs to come from pkgsBuildBuild, because it contains python scripts which get /nix/store/.../bin/python3 patched into their shebangs.
ghost
mentioned this pull request
ghost
marked this pull request as ready for review
|
Included in #229265 |
1 participant
Description of changes
What we call
ungoogled-chromiumis, contrary to its name, not a build of chromium. It is a copy of chromium's source code upon whichpatchShebangshas already been performed. Therefore it needs to come from buildPackages, because it contains python scripts which get/nix/store/.../bin/python3patched into their shebangs.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)