Skip to content

Comments

blisp: init at 0.0.4#227474

Closed
bdd wants to merge 1 commit intoNixOS:masterfrom
bdd:blisp-v0.0.3-init
Closed

blisp: init at 0.0.4#227474
bdd wants to merge 1 commit intoNixOS:masterfrom
bdd:blisp-v0.0.3-init

Conversation

@bdd
Copy link
Contributor

@bdd bdd commented Apr 21, 2023

In-System Programming (ISP) tool for Bouffalo Labs RISC-V MCUs.

Used for flashing BL60x, BL61x, BL70x, BL808 SoCs, and products using corresponding MCUs, like Pinecil V2.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 21, 2023
@Janik-Haag
Copy link
Member

Result of nixpkgs-review pr 227474 run on x86_64-linux 1

1 package built:
  • blisp

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly formatting nitpicks. I just flashed a pinecil v2 and it worked like a charm 😄

@Janik-Haag Janik-Haag mentioned this pull request Jul 14, 2023
12 tasks
@bbigras
Copy link
Contributor

bbigras commented Sep 8, 2023

Any progress on this?

Copy link
Contributor Author

@bdd bdd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reformatted with nix-community/nixpkgs-fmt. Dropped the full stop in description and prefixed it with an article.

@bdd bdd force-pushed the blisp-v0.0.3-init branch from 98026c3 to 215cc7b Compare September 8, 2023 23:35
An In-System Programming (ISP) tool for Bouffalo Labs RISC-V MCUs.

Used for flashing BL60x, BL61x, BL70x, BL808 SoCs, and products using
corresponding MCUs, like Pinecil V2.
@bdd bdd force-pushed the blisp-v0.0.3-init branch from 215cc7b to 2bc26c6 Compare September 8, 2023 23:37
@bdd bdd changed the title blisp: init at 0.0.3 blisp: init at 0.0.4 Sep 8, 2023
@bdd
Copy link
Contributor Author

bdd commented Sep 8, 2023

Already in tree.

@bdd bdd closed this Sep 8, 2023
@bdd bdd deleted the blisp-v0.0.3-init branch September 9, 2023 23:14
@Luflosi
Copy link
Contributor

Luflosi commented Nov 5, 2023

@bdd would you be interested in adding yourself as a maintainer to the blisp package that is now in tree?

@bdd
Copy link
Contributor Author

bdd commented Nov 10, 2023

@bdd would you be interested in adding yourself as a maintainer to the blisp package that is now in tree?

Looks current maintainer @fortuneteller2k is no longer on GitHub.
Sure, I can maintain blisp. I rely on it personally as well.
Should I just add myself or replace the defunct maintainer handle?

#266566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants