Skip to content

libmysofa: split headers to "dev" output#226505

Merged
trofi merged 1 commit intoNixOS:stagingfrom
trofi:libmysofa-dev-output
Apr 24, 2023
Merged

libmysofa: split headers to "dev" output#226505
trofi merged 1 commit intoNixOS:stagingfrom
trofi:libmysofa-dev-output

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Apr 16, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jfrankenau April 16, 2023 18:53
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Apr 16, 2023
@vcunat vcunat added the 6.topic: closure size The final size of a derivation, including its dependencies label Apr 17, 2023
@trofi trofi merged commit 2deee79 into NixOS:staging Apr 24, 2023
@trofi trofi deleted the libmysofa-dev-output branch April 24, 2023 20:46
vcunat added a commit that referenced this pull request Apr 30, 2023
@vcunat
libspatialaudio: fix libmysofa in .pc
705277a 
It got broken by libmysofa getting outputs in 2deee79 (PR #226505).
https://hydra.nixos.org/build/217838949/nixlog/1/tail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees

No one assigned

Labels

6.topic: closure size The final size of a derivation, including its dependencies 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@trofi @vcunat