Conversation
There was a problem hiding this comment.
Nit: please add some whitespace after the first and before the last brace in the
parameter list and around = in the name and version attributes below.
There was a problem hiding this comment.
I wish we have formatting tool :-) I'll fix
There was a problem hiding this comment.
Does this rely on submodules? If not, consider using a source archive, e.g., via fetchFromGitHub.
There was a problem hiding this comment.
nope, just simple repo.
Sure, I can change that. Does fetchFromGitHub has any advantage over that?
There was a problem hiding this comment.
@spinus yes, it's more bandwidth efficient and supports caching.
There was a problem hiding this comment.
(Using source archive that is, fetchFromGitHub is just a convenient way of doing it).
vrthra
added
0.kind: enhancement
|
@joachifm I fixed some stuff you mentioned. If you find a moment, please let me know if that is ok now. |
5 participants
Motivation for this change
Needed JWT token manipulation inside PostgreSQL (easier work with PostgREST).
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)