Merged
Conversation
upstream changelog: <https://gitlab.com/sequoia-pgp/sequoia/-/compare/sq%2Fv0.27.0...sq%2Fv0.28.0> changes to the nix package: - removes the cherry-picked 7916f90421 patch that made it into 0.28.0 - cherry-picks upstream commit 4dc6e624c2 which adds support for newer rust versions but didn't make the 0.28.0 release. see <NixOS#224806> - adds an update script. future routine updates can be automated with `nix-shell maintainers/scripts/update.nix --argstr package sequoia`
ofborg
bot
added
10.rebuild-darwin: 1-10
doronbehar
approved these changes
Apr 12, 2023
Contributor
doronbehar
left a comment
doronbehar
left a comment
There was a problem hiding this comment.
Thanks for the update! Changes look good and I trust you tested them.
vcunat
added a commit
that referenced
this pull request
Apr 12, 2023
...into staging-next In particular, this fixes build after rustc upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upstream changelog:
https://gitlab.com/sequoia-pgp/sequoia/-/compare/sq%2Fv0.27.0...sq%2Fv0.28.0
changes to the nix package:
nix-shell maintainers/scripts/update.nix --argstr package sequoiaDescription of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)