top-level: Allow nixpkgs to take localSystem directly#22575
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Feb 9, 2017
Merged
top-level: Allow nixpkgs to take localSystem directly#22575Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
|
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @nbp and @elitak to be potential reviewers. |
Ericson2314
force-pushed
the
localSystem
branch
from
387bd7d to
8c262e3
Compare
Ericson2314
added
the
6.topic: cross-compilation
shlevy
approved these changes
Feb 9, 2017
doc/cross-compilation.xml
Outdated
Member
There was a problem hiding this comment.
Maybe link to the relevant pages for now?
pkgs/top-level/default.nix
Outdated
This is instead of both system and platform, which is kind of ugly.
Ericson2314
force-pushed
the
localSystem
branch
from
8c262e3 to
8cd4c31
Compare
Member
Author
|
Tested again locally, so merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is instead of both system and platform, which is kind of ugly.
Motivation for this change
This lays the ground work for making sure
{build,host,cross}Platformcontain the same fields, harmonizing things likesystem(e.g. x86_64-linux) vs config (e.g. x86_64-unknown-linux-gnu).Things done
Ran the Travis script + no hashes are changed
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)