maintainers/scripts/update.nix: Remove unicode from message#224746
maintainers/scripts/update.nix: Remove unicode from message#224746SuperSandro2000 merged 1 commit intoNixOS:masterfrom
Conversation
…y with CONTRIBUTING.md
It's not used infrequently and the ascii version is nicer for automatic parsing.
```
git log --grep '->' --oneline --since '2022-01-01' | wc -l
67791
git log --grep '→' --oneline --since '2022-01-01' | wc -l
2914
```
You’re entitled to your opinion. My opinion is that the Unicode version is nicer, and automatic parsers should conform to the commit messages we actually have. (I’m willing to be overruled, but I think it’s important to note that our opinions differ.) |
Artturin
left a comment
There was a problem hiding this comment.
-> is the dominant one and used in CONTRIBUTING.md
It's also easy to type and minor aesthetics don't matter as we're not in a gallery
What repos are those |
As long as it's clear that we use that format, that's right. Currently, anyone who writes some one-off script without specifically knowing about this difference (e.g. me) will use the existing docs and expect To be clear, I'm not opposed to the unicode symbol being used. I'm proposing a bug fix where we document one format, but do something different. But the current state is broken. If we explicitly wants to use unicode, then we should make a different bug fix which:
Also, from the other comment:
That really depends on the system / layout / os, etc. I don't have the compose key, so when discussing this, I need to keep copy-pasting the symbol. |
but it isn't and this is the quickest fix to get it working and things inline with contributing. If ofborg and so on support the unicode character, we can revisit this. Also side note: I don't even know how to type the unicode version on my keyboard. |
I use
|
To my knowledge they are not accepted.
This was mostly about current new commit messages as eg ofborg is not parsing historic data. |
It is generally accepted that some share of commit messages do not follow CONTRIBUTING.md precisely. Getting to zero is hard, but if a safe change in a script can reduce the amount of deviations, that's a nice thing. |
|
A lot of those
If you commit via the CLI If using the If you use Kitty, you use You can also make your own macro, or add it to a keyboard layer if it is used enough (I added it to my phone keyboard). |
|
TIL
|
Remove unicode from message and comply with CONTRIBUTING.md:
It's not used frequently and the ascii version is nicer (because it's type-able regardless of layout) / expected (because it's documented) for automatic parsing.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)