Skip to content

Comments

Add AliceVision#224262

Closed
hesiod wants to merge 3 commits intoNixOS:masterfrom
hesiod:alice-vision
Closed

Add AliceVision#224262
hesiod wants to merge 3 commits intoNixOS:masterfrom
hesiod:alice-vision

Conversation

@hesiod
Copy link
Contributor

@hesiod hesiod commented Apr 1, 2023 •
edited
Loading

Description of changes

Add AliceVision.

Currently includes PR #216401 and commits updating Clp, Osi and adding CoinUtils. I might move the latter changes into another PR.
Edit: This PR is now independent of the other PRs.

Some features of AliceVision are not enabled in this PR because they require further testing/packaging, CUDA support being the most notable feature. I'm personally not interested in adding them at the moment, but others are welcome to add support.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@hesiod hesiod mentioned this pull request Apr 1, 2023
Draft
19 tasks
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Apr 1, 2023
@ofborg ofborg bot requested review from abbradar, ttuegel and vbgl April 1, 2023 20:01
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 1, 2023
@vbgl vbgl removed their request for review April 2, 2023 12:11
@hesiod hesiod requested review from davidak and removed request for abbradar and ttuegel April 2, 2023 12:12
@hesiod
Copy link
Contributor Author

hesiod commented Apr 2, 2023

I removed some reviewers that were picked up by Borg as a false positive (due to the contained other commits). Sorry for the noise. You're still welcome to review though.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Apr 2, 2023
@hesiod hesiod marked this pull request as ready for review April 2, 2023 13:49
@hesiod
Copy link
Contributor Author

hesiod commented Apr 2, 2023

Result of nixpkgs-review pr 224262 run on x86_64-linux 1

3 packages built:
  • alice-vision
  • alice-vision.dev
  • alice-vision.lib

@hesiod hesiod force-pushed the alice-vision branch 2 times, most recently from 8983de9 to eea47bb Compare April 4, 2023 00:39
@hesiod hesiod marked this pull request as draft April 4, 2023 14:01
@hesiod hesiod force-pushed the alice-vision branch 5 times, most recently from 668f369 to 6fb1084 Compare April 8, 2023 14:09
@hesiod
Copy link
Contributor Author

hesiod commented Apr 10, 2023

@ofborg eval
@ofborg build alice-vision

@hesiod hesiod force-pushed the alice-vision branch 2 times, most recently from 7767c49 to 11852f8 Compare April 14, 2023 13:04
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 14, 2023
@hesiod hesiod force-pushed the alice-vision branch 2 times, most recently from c5c5996 to 10dbc97 Compare April 14, 2023 14:21
@hesiod
Copy link
Contributor Author

hesiod commented May 23, 2023

Result of nixpkgs-review pr 224262 run on x86_64-linux 1

7 packages built:
  • alice-vision
  • alice-vision.dev
  • geogram
  • geogram.bin
  • geogram.dev
  • geogram.doc
  • geogram.lib

@hesiod hesiod marked this pull request as ready for review May 23, 2023 21:32
Laurent2916 added a commit to alicevision/AliceVision that referenced this pull request Jun 16, 2023
@Laurent2916
partially apply patches from NixOS/nixpkgs#224262
a115a2d
@pbsds
Copy link
Member

pbsds commented Jun 29, 2023 •
edited
Loading

Result of nixpkgs-review pr 224262 run on x86_64-linux 1

2 packages failed to build:
  • alice-vision
  • alice-vision.dev
5 packages built:
  • geogram
  • geogram.bin
  • geogram.dev
  • geogram.doc
  • geogram.lib
alice-vision> /build/source/src/aliceVision/fuseCut/DelaunayGraphCut.cpp:210:33: error: 'SearchParams' in namespace 'nanoflann' does not name a type; did you mean 'SearchParameters'?
alice-vision>   210 |         static const nanoflann::SearchParams searchParams(32, 0, false); // false: dont need to sort
alice-vision>       |                                 ^~~~~~~~~~~~
alice-vision>       |                                 SearchParameters
alice-vision> /build/source/src/aliceVision/fuseCut/DelaunayGraphCut.cpp:212:74: error: 'searchParams' was not declared in this scope
alice-vision>   212 |         kdTree.findNeighbors(resultSet, verticesCoordsPrepare[vIndex].m, searchParams);
alice-vision>       |                                                                          ^~~~~~~~~~~~
alice-vision> /build/source/src/aliceVision/fuseCut/DelaunayGraphCut.cpp: In function 'void aliceVision::fuseCut::createVerticesWithVisibilities(const aliceVision::StaticVector<int>&, std::vector<aliceVision::Point3d>&, std::vector<double>&, std::vector<float>&, std::vector<GC_vertexInfo>&, aliceVision::mvsUtils::MultiViewParams&, float, float, float, float)':
alice-vision> /build/source/src/aliceVision/fuseCut/DelaunayGraphCut.cpp:349:69: error: 'SearchParams' is not a member of 'nanoflann'; did you mean 'SearchParameters'?
alice-vision>   349 |                 if(!kdTree.findNeighbors(resultSet, p.m, nanoflann::SearchParams()))
alice-vision>       |                                                                     ^~~~~~~~~~~~
alice-vision>       |                                                                     SearchParameters

@zeuner
Copy link
Contributor

zeuner commented Sep 7, 2023

I just noticed this merge request when uploading another working (compiles and successfully runs reconstruction pipelines on x86_64) build: 8411621

What's the status? Maybe a mismatch in nanoflann versions?

@zeuner zeuner mentioned this pull request Sep 10, 2023
Open
13 tasks
@zeuner zeuner mentioned this pull request Sep 19, 2023
Draft
12 tasks
@luzpaz
Copy link
Contributor

luzpaz commented Jan 21, 2024

bumping for status. Asking due to #216403

@zeuner
Copy link
Contributor

zeuner commented Jan 21, 2024

bumping for status. Asking due to #216403

I started another PR for adding AliceVision: #256115

If there is interest, I can update it (needs a rebase by now).

@wegank wegank added 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 2.status: merge conflict This PR has merge conflicts with the target branch labels Mar 19, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 20, 2024
@SomeoneSerge SomeoneSerge mentioned this pull request Jun 11, 2024
Closed
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@donovanglover
Copy link
Member

donovanglover commented Feb 7, 2025

Superseded by #256115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidak davidak Awaiting requested review from davidak

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@hesiod @pbsds @zeuner @luzpaz @donovanglover @wegank