Skip to content

radicale2: Disable weak crypt htpasswd test#223241

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
mweinelt:radicale2-crypt-test
Mar 26, 2023
Merged

radicale2: Disable weak crypt htpasswd test#223241
vcunat merged 1 commit intoNixOS:staging-nextfrom
mweinelt:radicale2-crypt-test

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Mar 26, 2023

With our recent libxcrypt changes we don't support a lot of weak algorithms any longer, which made this test fail.

https://github.com/Kozea/Radicale/blob/9362b001b53a9d940c56dd2436ef1c2a1530aaa5/radicale/tests/test_auth.py#L96-L101

cc #221461, #220557

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

With our recent libxcrypt changes we don't support a lot of weak
algorithms any longer, which made this test fail.
@ofborg ofborg bot requested review from edwtjo, infinisil and pSub March 26, 2023 13:53
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 26, 2023
@vcunat vcunat merged commit 31c583a into NixOS:staging-next Mar 26, 2023
@dotlambda
Copy link
Member

I suggest we drop radicale2 completely.

@mweinelt mweinelt deleted the radicale2-crypt-test branch March 26, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants