Skip to content

perlPackages.Plack: add patch to avoid DES encrypted passwords in tests#223138

Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom
stigtsp:fix/Plack-test-replace-DES-with-bcrypt
Mar 26, 2023
Merged

perlPackages.Plack: add patch to avoid DES encrypted passwords in tests#223138
mweinelt merged 1 commit intoNixOS:staging-nextfrom
stigtsp:fix/Plack-test-replace-DES-with-bcrypt

Conversation

@stigtsp
Copy link
Member

@stigtsp stigtsp commented Mar 25, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested review from dasJ and zakame as code owners March 25, 2023 22:02
@stigtsp stigtsp mentioned this pull request Mar 25, 2023
6 tasks
@stigtsp stigtsp force-pushed the fix/Plack-test-replace-DES-with-bcrypt branch from d043b78 to 301d70d Compare March 25, 2023 22:21
@stigtsp stigtsp changed the base branch from staging to staging-next March 25, 2023 22:21
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Mar 25, 2023
@mweinelt
Copy link
Member

Result of nixpkgs-review pr 223138 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • perl534Packages.CatalystPluginUnicodeEncoding
  • perl536Packages.CatalystPluginUnicodeEncoding
4 packages failed to build:
  • perl534Packages.CatalystAuthenticationStoreHtpasswd
  • perl534Packages.CatalystAuthenticationStoreHtpasswd.devdoc
  • perl536Packages.CatalystAuthenticationStoreHtpasswd
  • perl536Packages.CatalystAuthenticationStoreHtpasswd.devdoc
295 packages built:
  • hydra_unstable
  • nix-serve
  • nix-simple-deploy
  • perl534Packages.CacheKyotoTycoon
  • perl534Packages.CacheKyotoTycoon.devdoc
  • perl534Packages.CatalystActionREST
  • perl534Packages.CatalystActionREST.devdoc
  • perl534Packages.CatalystActionRenderView
  • perl534Packages.CatalystActionRenderView.devdoc
  • perl534Packages.CatalystAuthenticationCredentialHTTP
  • perl534Packages.CatalystAuthenticationCredentialHTTP.devdoc
  • perl534Packages.CatalystAuthenticationStoreDBIxClass
  • perl534Packages.CatalystAuthenticationStoreDBIxClass.devdoc
  • perl534Packages.CatalystAuthenticationStoreLDAP
  • perl534Packages.CatalystAuthenticationStoreLDAP.devdoc
  • perl534Packages.CatalystComponentInstancePerContext
  • perl534Packages.CatalystComponentInstancePerContext.devdoc
  • perl534Packages.CatalystControllerHTMLFormFu
  • perl534Packages.CatalystControllerHTMLFormFu.devdoc
  • perl534Packages.CatalystControllerPOD
  • perl534Packages.CatalystControllerPOD.devdoc
  • perl534Packages.CatalystDevel
  • perl534Packages.CatalystDevel.devdoc
  • perl534Packages.CatalystDispatchTypeRegex
  • perl534Packages.CatalystDispatchTypeRegex.devdoc
  • perl534Packages.CatalystModelDBICSchema
  • perl534Packages.CatalystModelDBICSchema.devdoc
  • perl534Packages.CatalystPluginAccessLog
  • perl534Packages.CatalystPluginAccessLog.devdoc
  • perl534Packages.CatalystPluginAuthentication
  • perl534Packages.CatalystPluginAuthentication.devdoc
  • perl534Packages.CatalystPluginAuthorizationACL
  • perl534Packages.CatalystPluginAuthorizationACL.devdoc
  • perl534Packages.CatalystPluginAuthorizationRoles
  • perl534Packages.CatalystPluginAuthorizationRoles.devdoc
  • perl534Packages.CatalystPluginCache
  • perl534Packages.CatalystPluginCache.devdoc
  • perl534Packages.CatalystPluginCacheHTTP
  • perl534Packages.CatalystPluginCacheHTTP.devdoc
  • perl534Packages.CatalystPluginCaptcha
  • perl534Packages.CatalystPluginCaptcha.devdoc
  • perl534Packages.CatalystPluginConfigLoader
  • perl534Packages.CatalystPluginConfigLoader.devdoc
  • perl534Packages.CatalystPluginFormValidator
  • perl534Packages.CatalystPluginFormValidator.devdoc
  • perl534Packages.CatalystPluginFormValidatorSimple
  • perl534Packages.CatalystPluginFormValidatorSimple.devdoc
  • perl534Packages.CatalystPluginPrometheusTiny
  • perl534Packages.CatalystPluginPrometheusTiny.devdoc
  • perl534Packages.CatalystPluginSession
  • perl534Packages.CatalystPluginSession.devdoc
  • perl534Packages.CatalystPluginSessionDynamicExpiry
  • perl534Packages.CatalystPluginSessionDynamicExpiry.devdoc
  • perl534Packages.CatalystPluginSessionStateCookie
  • perl534Packages.CatalystPluginSessionStateCookie.devdoc
  • perl534Packages.CatalystPluginSessionStoreFastMmap
  • perl534Packages.CatalystPluginSessionStoreFastMmap.devdoc
  • perl534Packages.CatalystPluginSessionStoreFile
  • perl534Packages.CatalystPluginSessionStoreFile.devdoc
  • perl534Packages.CatalystPluginSmartURI
  • perl534Packages.CatalystPluginSmartURI.devdoc
  • perl534Packages.CatalystPluginStackTrace
  • perl534Packages.CatalystPluginStackTrace.devdoc
  • perl534Packages.CatalystPluginStaticSimple
  • perl534Packages.CatalystPluginStaticSimple.devdoc
  • perl534Packages.CatalystPluginStatusMessage
  • perl534Packages.CatalystPluginStatusMessage.devdoc
  • perl534Packages.CatalystRuntime
  • perl534Packages.CatalystRuntime.devdoc
  • perl534Packages.CatalystTraitForRequestProxyBase
  • perl534Packages.CatalystTraitForRequestProxyBase.devdoc
  • perl534Packages.CatalystViewCSV
  • perl534Packages.CatalystViewCSV.devdoc
  • perl534Packages.CatalystViewDownload
  • perl534Packages.CatalystViewDownload.devdoc
  • perl534Packages.CatalystViewJSON
  • perl534Packages.CatalystViewJSON.devdoc
  • perl534Packages.CatalystViewTT
  • perl534Packages.CatalystViewTT.devdoc
  • perl534Packages.CatalystXComponentTraits
  • perl534Packages.CatalystXComponentTraits.devdoc
  • perl534Packages.CatalystXRoleApplicator
  • perl534Packages.CatalystXRoleApplicator.devdoc
  • perl534Packages.CatalystXScriptServerStarman
  • perl534Packages.CatalystXScriptServerStarman.devdoc
  • perl534Packages.Catmandu
  • perl534Packages.Catmandu.devdoc
  • perl534Packages.Corona
  • perl534Packages.Corona.devdoc
  • perl534Packages.Furl
  • perl534Packages.Furl.devdoc
  • perl534Packages.HTMLMasonPSGIHandler
  • perl534Packages.HTMLMasonPSGIHandler.devdoc
  • perl534Packages.LWPUserAgentDNSHosts
  • perl534Packages.LWPUserAgentDNSHosts.devdoc
  • perl534Packages.NetAmazonS3
  • perl534Packages.NetAmazonS3.devdoc
  • perl534Packages.Plack
  • perl534Packages.Plack.devdoc
  • perl534Packages.PlackAppProxy
  • perl534Packages.PlackAppProxy.devdoc
  • perl534Packages.PlackMiddlewareAuthDigest
  • perl534Packages.PlackMiddlewareAuthDigest.devdoc
  • perl534Packages.PlackMiddlewareConsoleLogger
  • perl534Packages.PlackMiddlewareConsoleLogger.devdoc
  • perl534Packages.PlackMiddlewareDebug
  • perl534Packages.PlackMiddlewareDebug.devdoc
  • perl534Packages.PlackMiddlewareDeflater
  • perl534Packages.PlackMiddlewareDeflater.devdoc
  • perl534Packages.PlackMiddlewareFixMissingBodyInRedirect
  • perl534Packages.PlackMiddlewareFixMissingBodyInRedirect.devdoc
  • perl534Packages.PlackMiddlewareHeader
  • perl534Packages.PlackMiddlewareHeader.devdoc
  • perl534Packages.PlackMiddlewareMethodOverride
  • perl534Packages.PlackMiddlewareMethodOverride.devdoc
  • perl534Packages.PlackMiddlewareRemoveRedundantBody
  • perl534Packages.PlackMiddlewareRemoveRedundantBody.devdoc
  • perl534Packages.PlackMiddlewareReverseProxy
  • perl534Packages.PlackMiddlewareReverseProxy.devdoc
  • perl534Packages.PlackMiddlewareSession
  • perl534Packages.PlackMiddlewareSession.devdoc
  • perl534Packages.PlackTestExternalServer
  • perl534Packages.PlackTestExternalServer.devdoc
  • perl534Packages.PrometheusTiny
  • perl534Packages.PrometheusTiny.devdoc
  • perl534Packages.PrometheusTinyShared
  • perl534Packages.PrometheusTinyShared.devdoc
  • perl534Packages.Starlet
  • perl534Packages.Starlet.devdoc
  • perl534Packages.Starman
  • perl534Packages.Starman.devdoc
  • perl534Packages.TaskCatalystTutorial
  • perl534Packages.TaskCatalystTutorial.devdoc
  • perl534Packages.TaskPlack
  • perl534Packages.TaskPlack.devdoc
  • perl534Packages.TestFakeHTTPD
  • perl534Packages.TestFakeHTTPD.devdoc
  • perl534Packages.TestLWPUserAgent
  • perl534Packages.TestLWPUserAgent.devdoc
  • perl534Packages.TestWWWMechanizeCatalyst
  • perl534Packages.TestWWWMechanizeCatalyst.devdoc
  • perl534Packages.TestWWWMechanizePSGI
  • perl534Packages.TestWWWMechanizePSGI.devdoc
  • perl534Packages.Twiggy
  • perl534Packages.Twiggy.devdoc
  • perl534Packages.WebMachine
  • perl534Packages.WebMachine.devdoc
  • perl536Packages.CacheKyotoTycoon
  • perl536Packages.CacheKyotoTycoon.devdoc
  • perl536Packages.CatalystActionREST
  • perl536Packages.CatalystActionREST.devdoc
  • perl536Packages.CatalystActionRenderView
  • perl536Packages.CatalystActionRenderView.devdoc
  • perl536Packages.CatalystAuthenticationCredentialHTTP
  • perl536Packages.CatalystAuthenticationCredentialHTTP.devdoc
  • perl536Packages.CatalystAuthenticationStoreDBIxClass
  • perl536Packages.CatalystAuthenticationStoreDBIxClass.devdoc
  • perl536Packages.CatalystAuthenticationStoreLDAP
  • perl536Packages.CatalystAuthenticationStoreLDAP.devdoc
  • perl536Packages.CatalystComponentInstancePerContext
  • perl536Packages.CatalystComponentInstancePerContext.devdoc
  • perl536Packages.CatalystControllerHTMLFormFu
  • perl536Packages.CatalystControllerHTMLFormFu.devdoc
  • perl536Packages.CatalystControllerPOD
  • perl536Packages.CatalystControllerPOD.devdoc
  • perl536Packages.CatalystDevel
  • perl536Packages.CatalystDevel.devdoc
  • perl536Packages.CatalystDispatchTypeRegex
  • perl536Packages.CatalystDispatchTypeRegex.devdoc
  • perl536Packages.CatalystModelDBICSchema
  • perl536Packages.CatalystModelDBICSchema.devdoc
  • perl536Packages.CatalystPluginAccessLog
  • perl536Packages.CatalystPluginAccessLog.devdoc
  • perl536Packages.CatalystPluginAuthentication
  • perl536Packages.CatalystPluginAuthentication.devdoc
  • perl536Packages.CatalystPluginAuthorizationACL
  • perl536Packages.CatalystPluginAuthorizationACL.devdoc
  • perl536Packages.CatalystPluginAuthorizationRoles
  • perl536Packages.CatalystPluginAuthorizationRoles.devdoc
  • perl536Packages.CatalystPluginCache
  • perl536Packages.CatalystPluginCache.devdoc
  • perl536Packages.CatalystPluginCacheHTTP
  • perl536Packages.CatalystPluginCacheHTTP.devdoc
  • perl536Packages.CatalystPluginCaptcha
  • perl536Packages.CatalystPluginCaptcha.devdoc
  • perl536Packages.CatalystPluginConfigLoader
  • perl536Packages.CatalystPluginConfigLoader.devdoc
  • perl536Packages.CatalystPluginFormValidator
  • perl536Packages.CatalystPluginFormValidator.devdoc
  • perl536Packages.CatalystPluginFormValidatorSimple
  • perl536Packages.CatalystPluginFormValidatorSimple.devdoc
  • perl536Packages.CatalystPluginPrometheusTiny
  • perl536Packages.CatalystPluginPrometheusTiny.devdoc
  • perl536Packages.CatalystPluginSession
  • perl536Packages.CatalystPluginSession.devdoc
  • perl536Packages.CatalystPluginSessionDynamicExpiry
  • perl536Packages.CatalystPluginSessionDynamicExpiry.devdoc
  • perl536Packages.CatalystPluginSessionStateCookie
  • perl536Packages.CatalystPluginSessionStateCookie.devdoc
  • perl536Packages.CatalystPluginSessionStoreFastMmap
  • perl536Packages.CatalystPluginSessionStoreFastMmap.devdoc
  • perl536Packages.CatalystPluginSessionStoreFile
  • perl536Packages.CatalystPluginSessionStoreFile.devdoc
  • perl536Packages.CatalystPluginSmartURI
  • perl536Packages.CatalystPluginSmartURI.devdoc
  • perl536Packages.CatalystPluginStackTrace
  • perl536Packages.CatalystPluginStackTrace.devdoc
  • perl536Packages.CatalystPluginStaticSimple
  • perl536Packages.CatalystPluginStaticSimple.devdoc
  • perl536Packages.CatalystPluginStatusMessage
  • perl536Packages.CatalystPluginStatusMessage.devdoc
  • perl536Packages.CatalystRuntime
  • perl536Packages.CatalystRuntime.devdoc
  • perl536Packages.CatalystTraitForRequestProxyBase
  • perl536Packages.CatalystTraitForRequestProxyBase.devdoc
  • perl536Packages.CatalystViewCSV
  • perl536Packages.CatalystViewCSV.devdoc
  • perl536Packages.CatalystViewDownload
  • perl536Packages.CatalystViewDownload.devdoc
  • perl536Packages.CatalystViewJSON
  • perl536Packages.CatalystViewJSON.devdoc
  • perl536Packages.CatalystViewTT
  • perl536Packages.CatalystViewTT.devdoc
  • perl536Packages.CatalystXComponentTraits
  • perl536Packages.CatalystXComponentTraits.devdoc
  • perl536Packages.CatalystXRoleApplicator
  • perl536Packages.CatalystXRoleApplicator.devdoc
  • perl536Packages.CatalystXScriptServerStarman
  • perl536Packages.CatalystXScriptServerStarman.devdoc
  • perl536Packages.Catmandu
  • perl536Packages.Catmandu.devdoc
  • perl536Packages.Corona
  • perl536Packages.Corona.devdoc
  • perl536Packages.Furl
  • perl536Packages.Furl.devdoc
  • perl536Packages.HTMLMasonPSGIHandler
  • perl536Packages.HTMLMasonPSGIHandler.devdoc
  • perl536Packages.LWPUserAgentDNSHosts
  • perl536Packages.LWPUserAgentDNSHosts.devdoc
  • perl536Packages.NetAmazonS3
  • perl536Packages.NetAmazonS3.devdoc
  • perl536Packages.Plack
  • perl536Packages.Plack.devdoc
  • perl536Packages.PlackAppProxy
  • perl536Packages.PlackAppProxy.devdoc
  • perl536Packages.PlackMiddlewareAuthDigest
  • perl536Packages.PlackMiddlewareAuthDigest.devdoc
  • perl536Packages.PlackMiddlewareConsoleLogger
  • perl536Packages.PlackMiddlewareConsoleLogger.devdoc
  • perl536Packages.PlackMiddlewareDebug
  • perl536Packages.PlackMiddlewareDebug.devdoc
  • perl536Packages.PlackMiddlewareDeflater
  • perl536Packages.PlackMiddlewareDeflater.devdoc
  • perl536Packages.PlackMiddlewareFixMissingBodyInRedirect
  • perl536Packages.PlackMiddlewareFixMissingBodyInRedirect.devdoc
  • perl536Packages.PlackMiddlewareHeader
  • perl536Packages.PlackMiddlewareHeader.devdoc
  • perl536Packages.PlackMiddlewareMethodOverride
  • perl536Packages.PlackMiddlewareMethodOverride.devdoc
  • perl536Packages.PlackMiddlewareRemoveRedundantBody
  • perl536Packages.PlackMiddlewareRemoveRedundantBody.devdoc
  • perl536Packages.PlackMiddlewareReverseProxy
  • perl536Packages.PlackMiddlewareReverseProxy.devdoc
  • perl536Packages.PlackMiddlewareSession
  • perl536Packages.PlackMiddlewareSession.devdoc
  • perl536Packages.PlackTestExternalServer
  • perl536Packages.PlackTestExternalServer.devdoc
  • perl536Packages.PrometheusTiny
  • perl536Packages.PrometheusTiny.devdoc
  • perl536Packages.PrometheusTinyShared
  • perl536Packages.PrometheusTinyShared.devdoc
  • perl536Packages.Starlet
  • perl536Packages.Starlet.devdoc
  • perl536Packages.Starman
  • perl536Packages.Starman.devdoc
  • perl536Packages.TaskCatalystTutorial
  • perl536Packages.TaskCatalystTutorial.devdoc
  • perl536Packages.TaskPlack
  • perl536Packages.TaskPlack.devdoc
  • perl536Packages.TestFakeHTTPD
  • perl536Packages.TestFakeHTTPD.devdoc
  • perl536Packages.TestLWPUserAgent
  • perl536Packages.TestLWPUserAgent.devdoc
  • perl536Packages.TestWWWMechanizeCatalyst
  • perl536Packages.TestWWWMechanizeCatalyst.devdoc
  • perl536Packages.TestWWWMechanizePSGI
  • perl536Packages.TestWWWMechanizePSGI.devdoc
  • perl536Packages.Twiggy
  • perl536Packages.Twiggy.devdoc
  • perl536Packages.WebMachine
  • perl536Packages.WebMachine.devdoc
  • public-inbox
  • public-inbox.devdoc
  • public-inbox.sa_config
  • rt

@mweinelt
Copy link
Member

Replacing it with a bcrypt hash is fine with me.

@mweinelt mweinelt merged commit c94802a into NixOS:staging-next Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants