llvmPackages_git.llvm: run the tests on macOS by alyssais · Pull Request #222220 · NixOS/nixpkgs

alyssais · 2023-03-20T16:07:03Z

Description of changes

Port of c7231c0 ("llvmPackages_15.llvm: run the tests on macOS").

The sysctl native check input was taken from
6d0c876 ("llvmPackages_15.llvm: add in a missing check dep"), because it looks like it was supposed to be part of c7231c0 instead.

New PR for #220759, which I rebased badly.

Things done

alyssais · 2023-03-20T19:46:16Z

@ofborg build llvmPackages_git.llvm

adamcstephens · 2023-03-21T20:08:37Z

This failed for me on aarch64-darwin

FAIL: LLVM :: MC/ELF/cfi-version.ll (27957 of 44194)


-- Testing: 44194 tests, 8 workers --
FAIL: LLVM :: MC/ELF/cfi-version.ll (27957 of 44194)
******************** TEST 'LLVM :: MC/ELF/cfi-version.ll' FAILED ********************
Script:
--
: 'RUN: at line 1';   /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/llc /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/test/MC/ELF/cfi-version.ll -o - -dwarf-version 2 -filetype=obj | /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/llvm-dwarfdump -v - | /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/FileCheck /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/test/MC/ELF/cfi-version.ll --check-prefix=DWARF2
: 'RUN: at line 2';   /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/llc /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/test/MC/ELF/cfi-version.ll -o - -dwarf-version 3 -filetype=obj | /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/llvm-dwarfdump -v - | /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/FileCheck /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/test/MC/ELF/cfi-version.ll --check-prefix=DWARF3
: 'RUN: at line 3';   /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/llc /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/test/MC/ELF/cfi-version.ll -o - -dwarf-version 4 -filetype=obj | /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/llvm-dwarfdump -v - | /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/FileCheck /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/test/MC/ELF/cfi-version.ll --check-prefix=DWARF4
: 'RUN: at line 4';   /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/llc /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/test/MC/ELF/cfi-version.ll -o - -dwarf-version 5 -filetype=obj | /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/llvm-dwarfdump -v - | /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/bin/FileCheck /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/test/MC/ELF/cfi-version.ll --check-prefix=DWARF4
--
Exit Code: 1

Command Output (stderr):
--
/private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/test/MC/ELF/cfi-version.ll:43:11: error: DWARF2: expected string not found in input
; DWARF2: .debug_frame contents:
          ^
<stdin>:1:1: note: scanning from here
-: file format Mach-O arm64
^
<stdin>:61:1: note: possible intended match here
.debug_line contents:
^

Input file: <stdin>
Check file: /private/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/test/MC/ELF/cfi-version.ll

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            1: -: file format Mach-O arm64 
check:43'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
            2:  
check:43'0     ~
            3: .debug_abbrev contents: 
check:43'0     ~~~~~~~~~~~~~~~~~~~~~~~~
            4: Abbrev table for offset: 0x00000000 
check:43'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            5: [1] DW_TAG_compile_unit DW_CHILDREN_yes 
check:43'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            6:  DW_AT_producer DW_FORM_strp 
check:43'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            .
            .
            .
           56:  DW_AT_encoding [DW_FORM_data1] (DW_ATE_signed) 
check:43'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           57:  DW_AT_byte_size [DW_FORM_data1] (0x04) 
check:43'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           58:  
check:43'0     ~
           59: 0x00000054: NULL 
check:43'0     ~~~~~~~~~~~~~~~~~
           60:  
check:43'0     ~
           61: .debug_line contents: 
check:43'0     ~~~~~~~~~~~~~~~~~~~~~~
check:43'1     ?                      possible intended match
           62: debug_line[0x00000000] 
check:43'0     ~~~~~~~~~~~~~~~~~~~~~~~
           63: Line table prologue: 
check:43'0     ~~~~~~~~~~~~~~~~~~~~~
           64:  total_length: 0x00000036 
check:43'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~
           65:  format: DWARF32 
check:43'0     ~~~~~~~~~~~~~~~~~
           66:  version: 2 
check:43'0     ~~~~~~~~~~~~
            .
            .
            .
>>>>>>

--

********************
********************
Failed Tests (1):
  LLVM :: MC/ELF/cfi-version.ll


Testing Time: 877.59s
  Skipped          :     7
  Unsupported      :  1972
  Passed           : 48229
  Expectedly Failed:   176
  Failed           :     1
FAILED: CMakeFiles/check-all /tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/CMakeFiles/check-all 
cd /tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build && /nix/store/gl9hiqy6x9prqxs7iv6xg43bk1h9kl6c-python3-3.10.10-env/bin/python3.10 /tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/./bin/llvm-lit -svj8 --no-progress-bar --param polly_site_config=/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/tools/polly/test/lit.site.cfg --param polly_unit_site_config=/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/tools/polly/test/Unit/lit.site.cfg --param polly_site_config=/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/tools/polly/test/Unit/lit.site.cfg --param polly_site_config=/tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/tools/polly/test/UnitIsl/lit.site.cfg /tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/tools/polly/test /tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/tools/polly/test/Unit /tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/tools/polly/test/UnitIsl /tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/utils/lit /tmp/nix-build-llvm-unstable-2022-26-07.drv-0/llvm-src-unstable-2022-26-07/llvm/build/test
ninja: build stopped: subcommand failed.

RaitoBezarius · 2023-03-21T20:17:31Z

I'm not sure that debug frames sections are emitted on aarch64-darwin, it seems like a upstream bug to not skip the test on this platform.
They do it for Windows on x64 or arm64, I believe.

alyssais · 2023-03-21T22:25:04Z

it seems like a upstream bug to not skip the test on this platform.

Do you know why it might work on LLVM 15, where we already run the tests? Maybe there's some upstream change, or maybe we're doing something different in the remaining delta?

RaitoBezarius · 2023-03-21T23:13:16Z

Reading https://reviews.llvm.org/D67216 seems to indicate that .debug_frame should always be present on ARM toolchain.
(Potentially relevant: https://reviews.llvm.org/D87011).

I will investigate more tomorrow.

RaitoBezarius · 2023-03-22T12:15:03Z

Switching to llvm15 revision, I have those two errors:

LLVM :: MC/ELF/cfi-version.ll
LLVM-Unit :: Support/./SupportTests/HostTest/getMacOSHostVersion

Therefore, there's still a diff indeed missing.

rrbutani · 2023-03-22T18:38:21Z

@RaitoBezarius I just skipped that test on Darwin in #194634: 0ee5251 (this commit also has a fix for the HostTest/getMacOSHostVersion failure you're seeing). In retrospect I probably should have only skipped the test on aarch64 Darwin..

Upstream has indeed correctly gated this test in LLVM16+: llvm/llvm-project@3716851.

RaitoBezarius · 2023-03-22T18:39:18Z

@RaitoBezarius I just skipped that test on Darwin in #194634: 0ee5251 (this commit also has a fix for the HostTest/getMacOSHostVersion failure you're seeing).

Upstream has indeed correctly gated this test in LLVM16+: llvm/llvm-project@3716851.

Thanks for the details. We only need to do the same then, @alyssais.

rrbutani · 2023-03-22T18:46:16Z

Haven't tested locally (ofborg timed out) yet but I expect we'll also need parts of eafb8fb to get the tests to pass on x86_64-darwin.

Has anyone looked into the aarch64-linux failure already?

RaitoBezarius · 2023-03-22T18:49:16Z

Haven't tested locally (ofborg timed out) yet but I expect we'll also need parts of eafb8fb to get the tests to pass on x86_64-darwin.

Got it.

Has anyone looked into the aarch64-linux failure already?

Not yet.

RaitoBezarius · 2023-03-24T00:22:58Z

Tests are now fixed for aarch64-darwin, let's see what Ofborg has to say.

adamcstephens · 2023-03-24T02:55:44Z

This builds successfully for me now on aarch64-darwin.

RaitoBezarius · 2023-03-24T10:06:04Z

@ofborg build llvmPackages_git.llvm

rrbutani · 2023-03-24T11:30:28Z

@RaitoBezarius did you mean to squash the commits you pushed? (If so, I think it's still worth noting in the commit message that this includes fixes from 00839fe, 0ee5251, and abba4c313bcf515aceac1c9d96c61bd78b70f090)

Also the aarch64-linux FileCheck fail ofborg was seeing (our motivation for bumping llvmPackages_git to 15 before continuing to work on it) seems to have disappeared; pretty spooky 👀.

RaitoBezarius · 2023-03-25T12:15:45Z

@RaitoBezarius did you mean to squash the commits you pushed? (If so, I think it's still worth noting in the commit message that this includes fixes from 00839fe, 0ee5251, and abba4c3)

I have left them as-is so we can decide at the end what do we want to squash. :)
But please don't hesitate to rewrite the history accordingly.

Also the aarch64-linux FileCheck fail ofborg was seeing (our motivation for bumping llvmPackages_git to 15 before continuing to work on it) seems to have disappeared; pretty spooky eyes.

Heh. :)

RaitoBezarius · 2023-03-25T12:16:54Z

@ofborg build llvmPackages_git.llvm

RaitoBezarius

Good to go AFAIK. ofborg failures are timeouts, tested separately by contributors in this discussion.

Port of c7231c0 ("llvmPackages_15.llvm: run the tests on macOS"). The sysctl native check input was taken from 6d0c876 ("llvmPackages_15.llvm: add in a missing check dep"), because it looks like it was supposed to be part of c7231c0 instead.

RaitoBezarius · 2023-03-26T14:46:08Z

The PR is ready @alyssais @rrbutani ; formatted with the two original commits of LLVM15.

alyssais · 2023-03-26T15:40:14Z

Let's reference the original commit in the commit message, like I did?

Port of 0ee5251 ("llvmPackages_15.llvm: adjust a path, skip an xfail test on darwin")

RaitoBezarius · 2023-03-26T15:56:39Z

Let's reference the original commit in the commit message, like I did?

Done, will do the same for the other PRs. Apologies for the formatting back'n'forth. :)

alyssais · 2023-03-27T13:47:00Z

Looks fine to me now.

Port of eafb8fb ("llvmPackages_15.llvm: fix the tests on `x86_64-darwin`")

RaitoBezarius · 2023-03-28T11:10:09Z

With this: tests on (aarch64|x86_64)-darwin are passing. Retargeting master.

alyssais requested review from RaitoBezarius, rrbutani and trofi March 20, 2023 16:07

alyssais requested a review from matthewbauer as a code owner March 20, 2023 16:07

ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 20, 2023

trofi approved these changes Mar 20, 2023

View reviewed changes

RaitoBezarius marked this pull request as draft March 24, 2023 00:21

RaitoBezarius force-pushed the llvmPackages_git.llvm-tests-macos branch from 8c14365 to f67c00c Compare March 24, 2023 00:22

RaitoBezarius marked this pull request as ready for review March 24, 2023 00:22

RaitoBezarius force-pushed the llvmPackages_git.llvm-tests-macos branch from f67c00c to 7f6e59f Compare March 24, 2023 00:22

RaitoBezarius approved these changes Mar 26, 2023

View reviewed changes

RaitoBezarius mentioned this pull request Mar 26, 2023

llvmPackages_git.libcxx: LLVM15 changes and libcxxrt on FreeBSD #223255

Merged

12 tasks

RaitoBezarius force-pushed the llvmPackages_git.llvm-tests-macos branch 2 times, most recently from d55c631 to 94a151d Compare March 26, 2023 14:45

llvmPackages_git.llvm: adjust a path, skip an xfail test on darwin

3f9a9ad

Port of 0ee5251 ("llvmPackages_15.llvm: adjust a path, skip an xfail test on darwin")

RaitoBezarius force-pushed the llvmPackages_git.llvm-tests-macos branch from 94a151d to 3f9a9ad Compare March 26, 2023 15:56

rrbutani mentioned this pull request Mar 26, 2023

Tracking Issue for llvmPackages_15 changes #213033

Closed

48 tasks

llvmPackages_git.llvm: fix the tests on x86_64-darwin

5a4cfac

Port of eafb8fb ("llvmPackages_15.llvm: fix the tests on `x86_64-darwin`")

RaitoBezarius marked this pull request as draft March 28, 2023 11:12

RaitoBezarius changed the base branch from staging to master March 28, 2023 11:12

RaitoBezarius marked this pull request as ready for review March 28, 2023 11:12

rrbutani approved these changes Mar 28, 2023

View reviewed changes

RaitoBezarius merged commit 43c847c into NixOS:master Mar 28, 2023

alyssais deleted the llvmPackages_git.llvm-tests-macos branch March 28, 2023 19:27

rrbutani mentioned this pull request Apr 5, 2023

llvmPackages_git.openmp: apply #197674 (fix cross compile) #222903

Merged

12 tasks

rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024

Uh oh!

Conversation

alyssais commented Mar 20, 2023

Description of changes

Things done

Uh oh!

alyssais commented Mar 20, 2023

Uh oh!

adamcstephens commented Mar 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RaitoBezarius commented Mar 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alyssais commented Mar 21, 2023

Uh oh!

RaitoBezarius commented Mar 21, 2023

Uh oh!

RaitoBezarius commented Mar 22, 2023

Uh oh!

rrbutani commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RaitoBezarius commented Mar 22, 2023

Uh oh!

rrbutani commented Mar 22, 2023

Uh oh!

RaitoBezarius commented Mar 22, 2023

Uh oh!

RaitoBezarius commented Mar 24, 2023

Uh oh!

adamcstephens commented Mar 24, 2023

Uh oh!

RaitoBezarius commented Mar 24, 2023

Uh oh!

rrbutani commented Mar 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RaitoBezarius commented Mar 25, 2023

Uh oh!

RaitoBezarius commented Mar 25, 2023

Uh oh!

RaitoBezarius left a comment

Choose a reason for hiding this comment

Uh oh!

RaitoBezarius commented Mar 26, 2023

Uh oh!

alyssais commented Mar 26, 2023

Uh oh!

RaitoBezarius commented Mar 26, 2023

Uh oh!

alyssais commented Mar 27, 2023

Uh oh!

RaitoBezarius commented Mar 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

adamcstephens commented Mar 21, 2023 •

edited

Loading

RaitoBezarius commented Mar 21, 2023 •

edited

Loading

rrbutani commented Mar 22, 2023 •

edited

Loading

rrbutani commented Mar 24, 2023 •

edited

Loading