Skip to content

awscli2: fixup, downgrade ipython#221210

Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom
kirillrdy:staging-next
Mar 14, 2023
Merged

awscli2: fixup, downgrade ipython#221210
mweinelt merged 1 commit intoNixOS:staging-nextfrom
kirillrdy:staging-next

Conversation

@kirillrdy
Copy link
Member

@kirillrdy kirillrdy commented Mar 14, 2023

Description of changes

this is for staging-next fix awscli2 build

awscli2 and ipython depend on incompatible versions of prompt-toolkit, so this downgrades ipython just for awscli2 ( since its an app should be fine )

I am not sure why there is a new test failing that wasn't failing before 🤷

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@kirillrdy kirillrdy mentioned this pull request Mar 14, 2023
2 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 14, 2023
@mweinelt mweinelt merged commit f6de71c into NixOS:staging-next Mar 14, 2023
@kirillrdy kirillrdy deleted the staging-next branch March 15, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants