Skip to content

python310Packages.ntlm-auth: drop#221207

Merged
mweinelt merged 1 commit intoNixOS:staging-nextfrom
mweinelt:drop-python-ntlm-auth
Mar 14, 2023
Merged

python310Packages.ntlm-auth: drop#221207
mweinelt merged 1 commit intoNixOS:staging-nextfrom
mweinelt:drop-python-ntlm-auth

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Mar 14, 2023

The package relies on python providing support for md4 implementation.

But that support requires building python with a non-default openssl package, which reenables these legacy ciphers.

This stops now.

The package is also unmaintained, and the upstream recommends using pyspnego instead, which provides their own md4 implementation.

Targeting staging-next, because of a dependency on the updates requests-ntlm package.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Mar 14, 2023
@mweinelt mweinelt marked this pull request as draft March 14, 2023 19:59
@mweinelt mweinelt changed the base branch from master to staging-next March 14, 2023 20:00
@mweinelt mweinelt force-pushed the drop-python-ntlm-auth branch from 9554dc7 to 0efbca8 Compare March 14, 2023 20:00
The package relies on python providing support for md4 implementation.

But that support requires building python with a non-default openssl
package, which reenables these legacy ciphers.

The package is also unmaintained, and the upstream recommends using
pyspnego instead, which provides their own md4 implementation.
@mweinelt mweinelt force-pushed the drop-python-ntlm-auth branch from 0efbca8 to c9401eb Compare March 14, 2023 20:16
@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 14, 2023
@mweinelt mweinelt marked this pull request as ready for review March 14, 2023 21:29
@mweinelt mweinelt merged commit c089dfe into NixOS:staging-next Mar 14, 2023
@mweinelt mweinelt deleted the drop-python-ntlm-auth branch March 14, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant