Skip to content

llvmPackages_git.llvm: run the tests on macOS#220759

Closed
alyssais wants to merge 419 commits intoNixOS:stagingfrom
alyssais:llvmPackages_git.llvm-tests-macos
Closed

llvmPackages_git.llvm: run the tests on macOS#220759
alyssais wants to merge 419 commits intoNixOS:stagingfrom
alyssais:llvmPackages_git.llvm-tests-macos

Conversation

@alyssais
Copy link
Member

Description of changes

Port of c7231c0 ("llvmPackages_15.llvm: run the tests on macOS").

The sysctl native check input was taken from
6d0c876 ("llvmPackages_15.llvm: add in a missing check dep"), because it looks like it was supposed to be part of c7231c0 instead.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@alyssais alyssais requested a review from matthewbauer as a code owner March 12, 2023 01:53
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Mar 12, 2023
@RaitoBezarius
Copy link
Member

I don't understand why is there ofborg-eval errors.

@alyssais
Copy link
Member Author

I don't understand why is there ofborg-eval errors.

The following tests FAILED:
         15 - mutex_is_actually_mutex_test (Failed)
Errors while running CTest
make: *** [Makefile:71: test] Error 8
error: builder for '/nix/store/3v5dx5yhjq0djccja8637swzbkh5w514-aws-c-common-0.8.9.drv' failed with exit code 2;

So probably not related.

@ofborg eval

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Mar 12, 2023
@alyssais
Copy link
Member Author

@ofborg build llvmPackages_git.llvm

@alyssais
Copy link
Member Author

Would somebody mind checking this build on Darwin, since OfBorg can't?

figsoda and others added 18 commits March 18, 2023 20:45
Rust/cargo integration tests require available network.
Use gcc environment explicitly. The library manual does not mention
darwin explicitly and recommends only g++ as the compiler. Instead of
trying to patch the source to work with clang, just use g++ as expected.
exploitdb: 2023-03-15 -> 2023-03-17
@github-actions github-actions bot added 6.topic: emacs Text editor 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: kernel The Linux kernel 6.topic: nim Nim programing language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: vim Advanced text editor 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 20, 2023
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2023
@alyssais alyssais closed this Mar 20, 2023
@NixOS NixOS locked as too heated and limited conversation to collaborators Mar 20, 2023
@alyssais alyssais deleted the llvmPackages_git.llvm-tests-macos branch March 20, 2023 11:30
@rrbutani rrbutani added the 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related label May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: darwin Running or building packages on Darwin 6.topic: emacs Text editor 6.topic: erlang General-purpose, concurrent, functional high-level programming language 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: kernel The Linux kernel 6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 6.topic: nim Nim programing language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 6.topic: vim Advanced text editor 6.topic: vscode A free and versatile code editor that supports almost every major programming language. 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.