Skip to content

qt5.wrapQtAppsHook: move libs to depsTargetTargetPropagated#220518

Draft
Artturin wants to merge 2 commits intoNixOS:stagingfrom
Artturin:qthookcrossimp1
Draft

qt5.wrapQtAppsHook: move libs to depsTargetTargetPropagated#220518
Artturin wants to merge 2 commits intoNixOS:stagingfrom
Artturin:qthookcrossimp1

Conversation

@Artturin
Copy link
Member

@Artturin Artturin commented Mar 10, 2023

https://github.com/NixOS/nixpkgs/blob/master/doc/builders/special/makesetuphook.section.md

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Artturin Artturin mentioned this pull request Mar 10, 2023
Closed
@github-actions github-actions bot added the 6.topic: qt/kde Object-oriented framework for GUI creation label Mar 10, 2023
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Mar 10, 2023
@Artturin Artturin changed the base branch from master to staging March 10, 2023 20:09
@ghost
Copy link

ghost commented Mar 11, 2023

@ofborg build v4l-utils

@wineee wineee mentioned this pull request Mar 13, 2023
Merged
12 tasks
@Artturin
Copy link
Member Author

Artturin commented Mar 15, 2023 •
edited
Loading

qtbase propagatedBuildInputs a lot of packages which now won't be in PATH and nor will their propagatedBuildInputs be

most build==host breakages caused by this will be packages using buildPythonPackage(because it has strictDeps)

there will most likely be more cross breakages

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Mar 18, 2023

@ofborg eval

This was referenced Apr 24, 2023
Closed
Closed
@ghost
Copy link

ghost commented Oct 24, 2023

@Artturin any chance you might undraftify this? We should merge it.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. and removed 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. labels Oct 24, 2023
@Artturin
Copy link
Member Author

Artturin commented Oct 24, 2023

There's splicing issues due to the use of self so I'm fixing those

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 25, 2023
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 25, 2023
@ofborg ofborg bot requested review from OPNA2608, periklis and qknight October 25, 2023 02:45
@ofborg ofborg bot requested review from bkchr, matthewbauer and ttuegel October 25, 2023 02:45
@Artturin
Copy link
Member Author

Artturin commented Nov 1, 2023

Split the qt5: commits to #264903 because they're not breaking

@Artturin
frescobaldi: fix
3db4f8a 
broken by "qt5.wrapQtAppsHook: move libs to depsTargetTargetPropagated"
qtbase propagates a lot of stuff

frescobaldi> msgcat -o - frescobaldi/cs.po userguide/cs.po | msgfmt -o ../frescobaldi_app/i18n/cs.mo -
frescobaldi> sh: line 1: msgcat: command not found
frescobaldi> sh: line 1: msgfmt: command not found
@Artturin
qt5.wrapQtAppsHook: move libs to depsTargetTargetPropagated
bf69e21 
https://github.com/NixOS/nixpkgs/blob/master/doc/builders/special/makesetuphook.section.md
@ghost ghost mentioned this pull request Nov 12, 2023
Closed
13 tasks
@Artturin Artturin mentioned this pull request Nov 22, 2023
Merged
13 tasks
@wineee wineee mentioned this pull request Mar 21, 2024
Closed
13 tasks
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Sep 10, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 10, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jun 25, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OPNA2608 OPNA2608 Awaiting requested review from OPNA2608

@qknight qknight Awaiting requested review from qknight

@periklis periklis Awaiting requested review from periklis

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@ttuegel ttuegel Awaiting requested review from ttuegel

@bkchr bkchr Awaiting requested review from bkchr

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: qt/kde Object-oriented framework for GUI creation 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Artturin @SuperSandro2000 @wegank